Disable console.log() dumping to LogMessages

Disable console.log() dumping to LogMessages

Only dump console.log() to LogMessages if the page is a WebUI.  Don't dump any
other console.log() messages regardles of whether or not the WebContents is
incognito or not.

BUG=454569
Committed: https://crrev.com/e19cbf6a6f94dd3b4cfa667e675f99e09a5624da
Cr-Commit-Position: refs/heads/master@{#316002}

[David Trainor- moved to gerrit, 2015-02-11 22:24:16]

dtrainor@chromium.org changed reviewers:
+ creis@chromium.org, dzhioev@chromium.org

[David Trainor- moved to gerrit, 2015-02-11 22:24:17]

ptal.  Removing the log for everything but webui.  Thanks!

[Charlie Reis, 2015-02-12 01:06:03]

LGTM with nit.

https://codereview.chromium.org/921513002/diff/1/content/browser/frame_host/r...
File content/browser/frame_host/render_frame_host_impl.cc (right):

https://codereview.chromium.org/921513002/diff/1/content/browser/frame_host/r...
content/browser/frame_host/render_frame_host_impl.cc:644: // LogMessages should
only be created (as they can be persisted) with WebUI
nit: Update the comment to say why they shouldn't be logged in normal tabs
(i.e., for privacy reasons).  Right now it only says why they're need in the
WebUI case.

[David Trainor- moved to gerrit, 2015-02-12 01:14:44]

New patchsets have been uploaded after l-g-t-m from creis@chromium.org

[dzhioev (left Google), 2015-02-12 09:21:41]

On 2015/02/12 01:06:03, Charlie Reis wrote:
> LGTM with nit.
> 
>
https://codereview.chromium.org/921513002/diff/1/content/browser/frame_host/r...
> File content/browser/frame_host/render_frame_host_impl.cc (right):
> 
>
https://codereview.chromium.org/921513002/diff/1/content/browser/frame_host/r...
> content/browser/frame_host/render_frame_host_impl.cc:644: // LogMessages
should
> only be created (as they can be persisted) with WebUI
> nit: Update the comment to say why they shouldn't be logged in normal tabs
> (i.e., for privacy reasons).  Right now it only says why they're need in the
> WebUI case.

LGTM

[David Trainor- moved to gerrit, 2015-02-12 18:25:43]

The CQ bit was checked by dtrainor@chromium.org

[commit-bot: I haz the power, 2015-02-12 18:26:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/921513002/20001

[commit-bot: I haz the power, 2015-02-12 18:29:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-12 18:30:01]

Patchset 2 (id:??) landed as
https://crrev.com/e19cbf6a6f94dd3b4cfa667e675f99e09a5624da
Cr-Commit-Position: refs/heads/master@{#316002}

[mtomasz, 2015-02-13 16:56:31]

On 2015/02/12 18:30:01, I haz the power (commit-bot) wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/e19cbf6a6f94dd3b4cfa667e675f99e09a5624da
> Cr-Commit-Position: refs/heads/master@{#316002}

I'm concerned if this patch is correct. It disables output of JS test messages
to the console. As a result, we can't debug any failing JS tests on build bots,
try bots, and locally. See crbug.com/458446. How about enabling the output
redirection only for tests?

Since, the bug is Pri-2 can we revert this patch for now? It's really serious.
It's almost impossible to work on adding new JS tests and fixing existing
failures without logging.

[David Trainor- moved to gerrit, 2015-02-13 19:08:26]

On 2015/02/13 16:56:31, mtomasz wrote:
> On 2015/02/12 18:30:01, I haz the power (commit-bot) wrote:
> > Patchset 2 (id:??) landed as
> > https://crrev.com/e19cbf6a6f94dd3b4cfa667e675f99e09a5624da
> > Cr-Commit-Position: refs/heads/master@{#316002}
> 
> I'm concerned if this patch is correct. It disables output of JS test messages
> to the console. As a result, we can't debug any failing JS tests on build
bots,
> try bots, and locally. See crbug.com/458446. How about enabling the output
> redirection only for tests?
> 
> Since, the bug is Pri-2 can we revert this patch for now? It's really serious.
> It's almost impossible to work on adding new JS tests and fixing existing
> failures without logging.

Sure I'll revert this for now.  Sorry for messing up your work flows!  Do you
know of an easy way to only enable this for tests?  I think ideally we shouldn't
be relying on console.log() -> Chromium logs for testing.  For manual testing we
should be using dev tools to view the logs right?  For automated, I don't know
enough about the tests or the pipeline to know what we are/should be doing
honestly.

[David Trainor- moved to gerrit, 2015-02-13 19:08:45]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/927613003/ by dtrainor@chromium.org.

The reason for reverting is: Breaking existing test infrastructure and
workflows..