Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 921493003: Revert of Oilpan: Remove duplicated code between HeapPage and LargeObject (Closed)

Created:
5 years, 10 months ago by pdr.
Modified:
5 years, 10 months ago
Reviewers:
oilpan-reviews, haraken, sof
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Oilpan: Remove duplicated code between HeapPage and LargeObject (patchset #11 id:200001 of https://codereview.chromium.org/840223002/) Reason for revert: This change is being blamed for win_chromium_x64_rel_ng failures that are blocking the blink roll. See http://crbug.com/457808 for details. Original issue's description: > Oilpan: Remove duplicated code between HeapPage and LargeObject > > Basically, this CL changes: > > class ThreadHeap { > ...; // Methods for both HeapPages and LargeObjects > HeapPage* m_firstPage; > LargeObject* m_firstLargeObject; > }; > > to: > > class ThreadHeap { > ...; // Common methods between HeapPages and LargeObjects. > BaseHeapPage* m_firstPage; > }; > class ThreadHeapForHeapPage { ...; // Methods for HeapPages. } > class TheadHeapForLargeObject { ...; // Methods for LargeObjects. } > > and thus remove various duplicated code between HeapPage and LargeObject. To achieve the goal, this CL creates a dedicated ThreadHeap for LargeObjects (i.e., LargeObjectHeap). > > BUG=446386 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189782 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189953 TBR=oilpan-reviews@chromium.org,sigbjornf@opera.com,haraken@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=446386 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189981

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+374 lines, -277 lines) Patch
M Source/platform/heap/Heap.h View 19 chunks +103 lines, -95 lines 0 comments Download
M Source/platform/heap/Heap.cpp View 40 chunks +266 lines, -176 lines 0 comments Download
M Source/platform/heap/ThreadState.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/heap/ThreadState.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pdr.
Created Revert of Oilpan: Remove duplicated code between HeapPage and LargeObject
5 years, 10 months ago (2015-02-11 21:30:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921493003/1
5 years, 10 months ago (2015-02-11 21:32:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=189981
5 years, 10 months ago (2015-02-11 21:37:26 UTC) #3
haraken
5 years, 10 months ago (2015-02-12 01:00:56 UTC) #4
Message was sent while issue was closed.
On 2015/02/11 21:37:26, I haz the power (commit-bot) wrote:
> Committed patchset #1 (id:1) as
> https://src.chromium.org/viewvc/blink?view=rev&revision=189981

Thanks for taking care of this. I guess this CL won't be the culprit, but let me
test the win_chromium_x64_rel_ng bot before relanding. LGTM.

Powered by Google App Engine
This is Rietveld 408576698