extensions/renderer/guest_view/guest_view_container.h - Issue 921473006: GuestView: Fix message routing across embedder navigations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/guest_view/guest_view_container.h

Issue 921473006: GuestView: Fix message routing across embedder navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated comments CQ'ing Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/renderer/guest_view/extensions_guest_view_container.cc ('k') | extensions/renderer/guest_view/guest_view_container.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/guest_view/guest_view_container.h

diff --git a/extensions/renderer/guest_view/guest_view_container.h b/extensions/renderer/guest_view/guest_view_container.h

index 85af57af54289a3aa41271f0feb6e79a09fe6b2a..42ec6e14d6e47c8aa117ff803139595be15ee4b5 100644

--- a/extensions/renderer/guest_view/guest_view_container.h

+++ b/extensions/renderer/guest_view/guest_view_container.h

@@ -25,7 +25,6 @@ class GuestViewContainer : public content::BrowserPluginDelegate {

void SetElementInstanceID(int element_instance_id) override;

int element_instance_id() const { return element_instance_id_; }

- int render_view_routing_id() const { return render_view_routing_id_; }

content::RenderFrame* render_frame() const { return render_frame_; }

virtual void OnRenderFrameDestroyed() {}

@@ -34,7 +33,6 @@ class GuestViewContainer : public content::BrowserPluginDelegate {

class RenderFrameLifetimeObserver;

int element_instance_id_;

- const int render_view_routing_id_;

content::RenderFrame* render_frame_;

scoped_ptr<RenderFrameLifetimeObserver> render_frame_lifetime_observer_;