extensions/browser/guest_view/guest_view_message_filter.h - Issue 921473006: GuestView: Fix message routing across embedder navigations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/guest_view_message_filter.h

Issue 921473006: GuestView: Fix message routing across embedder navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated comments CQ'ing Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/guest_view_manager.cc ('k') | extensions/browser/guest_view/guest_view_message_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/guest_view_message_filter.h

diff --git a/extensions/browser/guest_view/guest_view_message_filter.h b/extensions/browser/guest_view/guest_view_message_filter.h

index 593b6315e676dc4c2ffc960f1fa7ca1bf2b5494f..1cb2be58c183ccce69d994dd393368836d0b72f7 100644

--- a/extensions/browser/guest_view/guest_view_message_filter.h

+++ b/extensions/browser/guest_view/guest_view_message_filter.h

@@ -49,8 +49,7 @@ class GuestViewMessageFilter : public content::BrowserMessageFilter {

bool OnMessageReceived(const IPC::Message& message) override;

// Message handlers on the UI thread.

- void OnAttachGuest(int routing_id,

- int element_instance_id,

+ void OnAttachGuest(int element_instance_id,

int guest_instance_id,

const base::DictionaryValue& attach_params);

void OnCreateMimeHandlerViewGuest(int render_frame_id,

« no previous file with comments | « extensions/browser/guest_view/guest_view_manager.cc ('k') | extensions/browser/guest_view/guest_view_message_filter.cc » ('j') | no next file with comments »