extensions/browser/guest_view/guest_view_base.cc - Issue 921473006: GuestView: Fix message routing across embedder navigations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/guest_view_base.cc

Issue 921473006: GuestView: Fix message routing across embedder navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated comments CQ'ing Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/guest_view/guest_view_base.cc

diff --git a/extensions/browser/guest_view/guest_view_base.cc b/extensions/browser/guest_view/guest_view_base.cc

index 9cc55467af42d2dc1f752b58e605b07e271dea32..14754dce45061e29c950a710d3b064344a3ce6ff 100644

--- a/extensions/browser/guest_view/guest_view_base.cc

+++ b/extensions/browser/guest_view/guest_view_base.cc

@@ -395,8 +395,7 @@ void GuestViewBase::DidAttach(int guest_proxy_routing_id) {

}

void GuestViewBase::DidDetach() {

- GuestViewManager::FromBrowserContext(browser_context_)->DetachGuest(

- this, element_instance_id_);

+ GuestViewManager::FromBrowserContext(browser_context_)->DetachGuest(this);

StopTrackingEmbedderZoomLevel();

owner_web_contents()->Send(new GuestViewMsg_GuestDetached(

element_instance_id_));

« no previous file with comments | « content/public/browser/browser_plugin_guest_manager.cc ('k') | extensions/browser/guest_view/guest_view_manager.h » ('j') | no next file with comments »