content/browser/frame_host/frame_accessibility.cc - Issue 921473006: GuestView: Fix message routing across embedder navigations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/frame_accessibility.cc

Issue 921473006: GuestView: Fix message routing across embedder navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated comments CQ'ing Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/browser_plugin/browser_plugin_message_filter.cc ('k') | content/browser/frame_host/render_frame_host_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/frame_accessibility.cc

diff --git a/content/browser/frame_host/frame_accessibility.cc b/content/browser/frame_host/frame_accessibility.cc

index 39b1e0e62aa4f05eba47542c389fcf3c08e30c76..89347175965028170dd3ea8f3c222110fe124f63 100644

--- a/content/browser/frame_host/frame_accessibility.cc

+++ b/content/browser/frame_host/frame_accessibility.cc

@@ -112,6 +112,7 @@ RenderFrameHostImpl* FrameAccessibility::GetChild(

if (iter->browser_plugin_instance_id) {

RenderFrameHost* guest =

parent_frame_host->delegate()->GetGuestByInstanceID(

+ iter->parent_frame_host,

iter->browser_plugin_instance_id);

if (guest)

return static_cast<RenderFrameHostImpl*>(guest);

@@ -142,6 +143,7 @@ void FrameAccessibility::GetAllChildFrames(

if (iter->browser_plugin_instance_id) {

RenderFrameHost* guest =

parent_frame_host->delegate()->GetGuestByInstanceID(

+ iter->parent_frame_host,

iter->browser_plugin_instance_id);

if (guest)

child_frame_hosts->push_back(static_cast<RenderFrameHostImpl*>(guest));

@@ -185,6 +187,7 @@ bool FrameAccessibility::GetParent(

if (iter->browser_plugin_instance_id) {

RenderFrameHost* guest =

iter->parent_frame_host->delegate()->GetGuestByInstanceID(

+ iter->parent_frame_host,

iter->browser_plugin_instance_id);

if (guest == child_frame_host) {

if (out_parent_frame_host)