Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: ui/events/latency_info.h

Issue 921473003: Break down end-to-end scroll update latency UMA metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/latency_info.h
diff --git a/ui/events/latency_info.h b/ui/events/latency_info.h
index c3a52b87336ece4b10c4a6a814fad79abd7a1d99..b6724b86154ac8dce6948aa4d0ac697bfb768384 100644
--- a/ui/events/latency_info.h
+++ b/ui/events/latency_info.h
@@ -35,8 +35,11 @@ enum LatencyComponentType {
// Timestamp when the UI event is created.
INPUT_EVENT_LATENCY_UI_COMPONENT,
// This is special component indicating there is rendering scheduled for
- // the event associated with this LatencyInfo.
- INPUT_EVENT_LATENCY_RENDERING_SCHEDULED_COMPONENT,
+ // the event associated with this LatencyInfo on main thread.
+ INPUT_EVENT_LATENCY_RENDERING_SCHEDULED_MAIN_COMPONENT,
+ // This is special component indicating there is rendering scheduled for
+ // the event associated with this LatencyInfo on impl thread.
+ INPUT_EVENT_LATENCY_RENDERING_SCHEDULED_IMPL_COMPONENT,
// Timestamp when a scroll update is forwarded to the main thread.
INPUT_EVENT_LATENCY_FORWARD_SCROLL_UPDATE_TO_MAIN_COMPONENT,
// Timestamp when the event's ack is received by the RWH.
@@ -50,6 +53,8 @@ enum LatencyComponentType {
WINDOW_OLD_SNAPSHOT_FRAME_NUMBER_COMPONENT,
// Timestamp when a tab is requested to be shown.
TAB_SHOW_COMPONENT,
+ // Timestamp when the frame is swapped in renderer.
+ INPUT_EVENT_LATENCY_RENDERER_SWAP_COMPONENT,
// Timestamp of when the browser process receives a buffer swap notification
// from the renderer.
INPUT_EVENT_BROWSER_RECEIVED_RENDERER_SWAP_COMPONENT,
@@ -106,7 +111,7 @@ struct EVENTS_BASE_EXPORT LatencyInfo {
};
// Empirically determined constant based on a typical scroll sequence.
- enum { kTypicalMaxComponentsPerLatencyInfo = 9 };
+ enum { kTypicalMaxComponentsPerLatencyInfo = 10 };
enum { kMaxInputCoordinates = 2 };

Powered by Google App Engine
This is Rietveld 408576698