cc/trees/layer_tree_host_impl.cc - Issue 921473003: Break down end-to-end scroll update latency UMA metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host_impl.cc

Issue 921473003: Break down end-to-end scroll update latency UMA metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: pretty-printing histograms.xml Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « cc/base/latency_info_swap_promise_monitor.cc ('k') | content/browser/renderer_host/render_widget_host_latency_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cc/trees/layer_tree_host_impl.cc

diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc

index 95e1ab1866834c9582ad4f95a117bbdbc44f97f2..cb977d85ced57891870491767159ff6f2868e21d 100644

--- a/cc/trees/layer_tree_host_impl.cc

+++ b/cc/trees/layer_tree_host_impl.cc

@@ -1650,12 +1650,19 @@ bool LayerTreeHostImpl::SwapBuffers(const LayerTreeHostImpl::FrameData& frame) {

}

CompositorFrameMetadata metadata = MakeCompositorFrameMetadata();

active_tree()->FinishSwapPromises(&metadata);

- for (size_t i = 0; i < metadata.latency_info.size(); i++) {

+ for (auto& latency : metadata.latency_info) {

TRACE_EVENT_FLOW_STEP0(

"input,benchmark",

"LatencyInfo.Flow",

- TRACE_ID_DONT_MANGLE(metadata.latency_info[i].trace_id),

+ TRACE_ID_DONT_MANGLE(latency.trace_id),

"SwapBuffers");

+ // Only add the latency component once for renderer swap, not the browser

+ // swap.

+ if (!latency.FindLatency(ui::INPUT_EVENT_LATENCY_RENDERER_SWAP_COMPONENT,

+ 0, nullptr)) {

+ latency.AddLatencyNumber(ui::INPUT_EVENT_LATENCY_RENDERER_SWAP_COMPONENT,

+ 0, 0);

+ }

}

renderer_->SwapBuffers(metadata);

return true;