net/url_request/url_request.cc - Issue 921453003: Allow URLRequest::AppendChunkToUpload to take 0-byte final chunks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request.cc

Issue 921453003: Allow URLRequest::AppendChunkToUpload to take 0-byte final chunks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reduce tests, refactor out some of the boilerplate, merge some lines Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/url_request/url_request.cc

diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc

index af06e3503b32c5b4a25d196798e5b2528268728d..d75a19c44899bd46f691970f57002448fba8c702 100644

--- a/net/url_request/url_request.cc

+++ b/net/url_request/url_request.cc

@@ -210,7 +210,6 @@ void URLRequest::AppendChunkToUpload(const char* bytes,

bool is_last_chunk) {

DCHECK(upload_data_stream_);

DCHECK(upload_data_stream_->is_chunked());

- DCHECK_GT(bytes_len, 0);

upload_chunked_data_stream_->AppendData(bytes, bytes_len, is_last_chunk);

}

« no previous file with comments | « net/url_request/url_request.h ('k') | no next file » | no next file with comments »