Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 921443004: Get code flags from compilation info. (Closed)

Created:
5 years, 10 months ago by Sven Panne
Modified:
5 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Get code flags from compilation info. Removed useless (and in the future incorrect) DCHECKs on the way. Committed: https://crrev.com/56f9cca8f1cc6ccb522ee8dafd3874d3b6082a66 Cr-Commit-Position: refs/heads/master@{#26655}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M src/compiler/code-generator.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sven Panne
5 years, 10 months ago (2015-02-16 10:43:28 UTC) #2
Michael Starzinger
LGTM.
5 years, 10 months ago (2015-02-16 10:56:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921443004/1
5 years, 10 months ago (2015-02-16 10:58:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-16 11:04:28 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 11:04:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56f9cca8f1cc6ccb522ee8dafd3874d3b6082a66
Cr-Commit-Position: refs/heads/master@{#26655}

Powered by Google App Engine
This is Rietveld 408576698