chrome/browser/geolocation/geolocation_permission_context_unittest.cc - Issue 921443003: Fix RenderFrameCreated and RenderFrameDeleted WebContentsObserver methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_permission_context_unittest.cc

Issue 921443003: Fix RenderFrameCreated and RenderFrameDeleted WebContentsObserver methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Delete pending callbacks in ManifestManagerHost destructor. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/background/background_contents.cc ('k') | chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/geolocation_permission_context_unittest.cc

diff --git a/chrome/browser/geolocation/geolocation_permission_context_unittest.cc b/chrome/browser/geolocation/geolocation_permission_context_unittest.cc

index fa79aa8bfdf6c33cc9a9ba8158cfcfe8b95068d4..111844d8622d6903bdcd9945af6e274faffa5214 100644

--- a/chrome/browser/geolocation/geolocation_permission_context_unittest.cc

+++ b/chrome/browser/geolocation/geolocation_permission_context_unittest.cc

@@ -220,8 +220,7 @@ void GeolocationPermissionContextTests::CheckPermissionMessageSentInternal(

}

void GeolocationPermissionContextTests::AddNewTab(const GURL& url) {

- content::WebContents* new_tab = content::WebContents::Create(

- content::WebContents::CreateParams(profile()));

+ content::WebContents* new_tab = CreateTestWebContents();

new_tab->GetController().LoadURL(

url, content::Referrer(), ui::PAGE_TRANSITION_TYPED, std::string());

content::RenderFrameHostTester::For(new_tab->GetMainFrame())