content/public/browser/web_contents.cc - Issue 921443003: Fix RenderFrameCreated and RenderFrameDeleted WebContentsObserver methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/web_contents.cc

Issue 921443003: Fix RenderFrameCreated and RenderFrameDeleted WebContentsObserver methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Geolocation unit tests to create TestWebContents instead of regular WebContents. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/web_contents.h ('K') | « content/public/browser/web_contents.h ('k') | content/public/test/web_contents_observer_sanity_checker.h » ('j') | content/public/test/web_contents_observer_sanity_checker.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/web_contents.cc

diff --git a/content/public/browser/web_contents.cc b/content/public/browser/web_contents.cc

index 676841113d404d83bb9ff91ac962b89c039f1d5e..69b28044504e27a7b869aae1000fe6b45e22cc3e 100644

--- a/content/public/browser/web_contents.cc

+++ b/content/public/browser/web_contents.cc

@@ -17,7 +17,8 @@ WebContents::CreateParams::CreateParams(BrowserContext* context)

main_frame_routing_id(MSG_ROUTING_NONE),

initially_hidden(false),

guest_delegate(nullptr),

- context(nullptr) {}

+ context(nullptr),

+ renderer_created(false) {}

WebContents::CreateParams::CreateParams(

BrowserContext* context, SiteInstance* site)

@@ -29,7 +30,8 @@ WebContents::CreateParams::CreateParams(