Fix RenderFrameCreated and RenderFrameDeleted WebContentsObserver methods

content/browser/frame_host/frame_tree_unittest.cc

Index: content/browser/frame_host/frame_tree_unittest.cc
diff --git a/content/browser/frame_host/frame_tree_unittest.cc b/content/browser/frame_host/frame_tree_unittest.cc
index 6ee69fc52b7e1bbc8e8d7bb9048e0324e637a03a..4df5e1de1ed20ae4250bf3f28071a83fee83a11f 100644
--- a/content/browser/frame_host/frame_tree_unittest.cc
+++ b/content/browser/frame_host/frame_tree_unittest.cc
@@ -69,9 +69,13 @@ class TreeWalkingWebContentsLogger : public WebContentsObserver {
 
   void RenderFrameHostChanged(RenderFrameHost* old_host,
                               RenderFrameHost* new_host) override {
+    // TODO(nasko): Re-enable this logging once RenderFrameHostChanged observer

[Charlie Reis, 2015/02/12 00:29:31]

I don't see these logging messages checked anywhere, so I'm not sure what breaks
if they're on.  Is there a need to disable them?  (Maybe they started showing up
in the logs when they didn't before?)

(If we do need this, let's list a bug number in the TODO.)

[nasko, 2015/02/12 17:52:26]

It starts showing up, which violates the expectations. Since this is for the
RenderFrameHostChanged, I want to disable it and fix it with the work of fixing
RenderFrameHostChanged itself.

+    // methods are fixed.
+    /*
     if (old_host)
       LogWhatHappened("RenderFrameChanged(old)", old_host);
     LogWhatHappened("RenderFrameChanged(new)", new_host);
+    */
   }
 
   void RenderFrameDeleted(RenderFrameHost* render_frame_host) override {
@@ -229,11 +233,13 @@ TEST_F(FrameTreeTest, ObserverWalksTreeAfterCrash) {
   EXPECT_EQ("RenderFrameCreated(23) -> 1: [22: [], 23: []]", activity.GetLog());
 
   // Crash the renderer
-  main_rfh()->OnMessageReceived(FrameHostMsg_RenderProcessGone(
-      0, base::TERMINATION_STATUS_PROCESS_CRASHED, -1));
+  main_test_rfh()->OnMessageReceived(FrameHostMsg_RenderProcessGone(
+      main_test_rfh()->GetRoutingID(), base::TERMINATION_STATUS_PROCESS_CRASHED,
+      -1));
   EXPECT_EQ(
       "RenderFrameDeleted(22) -> 1: []\n"
       "RenderFrameDeleted(23) -> 1: []\n"
+      "RenderFrameDeleted(1) -> 1: []\n"
       "RenderProcessGone -> 1: []",
       activity.GetLog());
 }