Fix RenderFrameCreated and RenderFrameDeleted WebContentsObserver methods

content/public/test/web_contents_observer_sanity_checker.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_TEST_WEB_CONTENTS_OBSERVER_SANITY_CHECKER_H_
 #define CONTENT_PUBLIC_TEST_WEB_CONTENTS_OBSERVER_SANITY_CHECKER_H_
 
 #include <set>
 #include <string>
 
@@ skipping 66 matching lines @@
                            ui::PageTransition transition) override;
   bool OnMessageReceived(const IPC::Message& message,
                          RenderFrameHost* render_frame_host) override;
   void WebContentsDestroyed() override;
 
  private:
   explicit WebContentsObserverSanityChecker(WebContents* web_contents);
   ~WebContentsObserverSanityChecker() override;
 
   std::string Format(RenderFrameHost* render_frame_host);
-  void AssertFrameExists(RenderFrameHost* render_frame_host);
+  void AssertRenderFrameExists(RenderFrameHost* render_frame_host);
   void AssertMainFrameExists();
 
+  std::set<std::pair<int, int>> current_hosts_;
+  std::set<std::pair<int, int>> deleted_hosts_;
   std::set<std::pair<int, int>> live_routes_;
   std::set<std::pair<int, int>> deleted_routes_;
+  base::hash_map<std::pair<int, int>, std::string> render_frame_created_stacks_;

[Charlie Reis, 2015/02/12 00:29:31]

I think we should leave this out of this CL.  If we want to add it for
debug-only logging, let's do that in a follow-up CL so that it's easier to read
in git blame.

[nasko, 2015/02/12 17:52:26]

Done.

+  base::hash_map<std::pair<int, int>, std::string> render_frame_deleted_stacks_;
+
   bool web_contents_destroyed_;
 
   DISALLOW_COPY_AND_ASSIGN(WebContentsObserverSanityChecker);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_TEST_WEB_CONTENTS_OBSERVER_SANITY_CHECKER_H_