Fix RenderFrameCreated and RenderFrameDeleted WebContentsObserver methods

content/public/browser/web_contents.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
 
 #include <set>
 
 #include "base/basictypes.h"
@@ skipping 104 matching lines @@
 
     // True if the contents should be initially hidden.
     bool initially_hidden;
 
     // If non-null then this WebContents will be hosted by a BrowserPlugin.
     BrowserPluginGuestDelegate* guest_delegate;
 
     // Used to specify the location context which display the new view should
     // belong. This can be nullptr if not needed.
     gfx::NativeView context;
+
+    // Created by the renderer process.
+    bool renderer_created;

[Charlie Reis, 2015/02/12 00:29:31]

Hmm, this is kind of difficult to understand without looking at the
implementation.  CreateParams are instructions to the WebContents constructor,
so let's clarify when callers should set this to true.

As is, it might mean any of the following (or something else):
 - This WC will definitely be put into an existing renderer process.
 - A renderer process asked for this WC to be created, but it could end up in a
new/different process.
 - A renderer process asked for this WC to be created, and thus its main
RenderFrame has already been created (?).

[nasko, 2015/02/12 17:52:26]

It is the last one of them. I've renamed the parameter and added a better
comment.

   };
 
   // Creates a new WebContents.
   CONTENT_EXPORT static WebContents* Create(const CreateParams& params);
 
   // Similar to Create() above but should be used when you need to prepopulate
   // the SessionStorageNamespaceMap of the WebContents. This can happen if
   // you duplicate a WebContents, try to reconstitute it from a saved state,
   // or when you create a new WebContents based on another one (eg., when
   // servicing a window.open() call).
@@ skipping 483 matching lines @@
 
  private:
   // This interface should only be implemented inside content.
   friend class WebContentsImpl;
   WebContents() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_