Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 921443003: Fix RenderFrameCreated and RenderFrameDeleted WebContentsObserver methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Geolocation unit tests to create TestWebContents instead of regular WebContents. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_view_host_impl.h" 5 #include "content/browser/renderer_host/render_view_host_impl.h"
6 6
7 #include <set> 7 #include <set>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
310 SetInitialRenderSizeParams(params.initial_size); 310 SetInitialRenderSizeParams(params.initial_size);
311 311
312 // If it's enabled, tell the renderer to set up the Javascript bindings for 312 // If it's enabled, tell the renderer to set up the Javascript bindings for
313 // sending messages back to the browser. 313 // sending messages back to the browser.
314 if (GetProcess()->IsIsolatedGuest()) 314 if (GetProcess()->IsIsolatedGuest())
315 DCHECK_EQ(0, enabled_bindings_); 315 DCHECK_EQ(0, enabled_bindings_);
316 Send(new ViewMsg_AllowBindings(GetRoutingID(), enabled_bindings_)); 316 Send(new ViewMsg_AllowBindings(GetRoutingID(), enabled_bindings_));
317 // Let our delegate know that we created a RenderView. 317 // Let our delegate know that we created a RenderView.
318 delegate_->RenderViewCreated(this); 318 delegate_->RenderViewCreated(this);
319 319
320 // Since this method creates the main RenderFrame in the renderer process,
321 // set the proper state on its corresponding RenderFrameHost.
322 RenderFrameHostImpl::FromID(GetProcess()->GetID(), main_frame_routing_id_)
323 ->SetRenderFrameCreated(true);
324
320 return true; 325 return true;
321 } 326 }
322 327
323 bool RenderViewHostImpl::IsRenderViewLive() const { 328 bool RenderViewHostImpl::IsRenderViewLive() const {
324 return GetProcess()->HasConnection() && renderer_initialized_; 329 return GetProcess()->HasConnection() && renderer_initialized_;
325 } 330 }
326 331
327 void RenderViewHostImpl::SyncRendererPrefs() { 332 void RenderViewHostImpl::SyncRendererPrefs() {
328 Send(new ViewMsg_SetRendererPrefs(GetRoutingID(), 333 Send(new ViewMsg_SetRendererPrefs(GetRoutingID(),
329 delegate_->GetRendererPrefs( 334 delegate_->GetRendererPrefs(
(...skipping 1134 matching lines...) Expand 10 before | Expand all | Expand 10 after
1464 FrameTree* frame_tree = delegate_->GetFrameTree(); 1469 FrameTree* frame_tree = delegate_->GetFrameTree();
1465 1470
1466 frame_tree->ResetForMainFrameSwap(); 1471 frame_tree->ResetForMainFrameSwap();
1467 } 1472 }
1468 1473
1469 void RenderViewHostImpl::SelectWordAroundCaret() { 1474 void RenderViewHostImpl::SelectWordAroundCaret() {
1470 Send(new ViewMsg_SelectWordAroundCaret(GetRoutingID())); 1475 Send(new ViewMsg_SelectWordAroundCaret(GetRoutingID()));
1471 } 1476 }
1472 1477
1473 } // namespace content 1478 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698