Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 921393002: Autofill: Use the title attribute as a last resort for finding labels (Closed)

Created:
5 years, 10 months ago by Lei Zhang
Modified:
5 years, 10 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autofill: Use the title attribute as a last resort for finding labels. Committed: https://crrev.com/036f121626d6a37fcfa41cdd0ba7d82b5cd15db9 Cr-Commit-Position: refs/heads/master@{#316711}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M chrome/test/data/autofill/heuristics/output/05_checkout_overstock.com.out View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/11_register_macys.com.out View 1 chunk +3 lines, -3 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Lei Zhang
5 years, 10 months ago (2015-02-14 00:47:49 UTC) #2
Evan Stade
lgtm
5 years, 10 months ago (2015-02-14 01:02:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921393002/1
5 years, 10 months ago (2015-02-17 23:22:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-18 00:33:39 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/036f121626d6a37fcfa41cdd0ba7d82b5cd15db9 Cr-Commit-Position: refs/heads/master@{#316711}
5 years, 10 months ago (2015-02-18 00:34:20 UTC) #7
Lei Zhang
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/934173002/ by thestig@chromium.org. ...
5 years, 10 months ago (2015-02-18 02:18:15 UTC) #8
Evan Stade
5 years, 10 months ago (2015-02-18 02:29:43 UTC) #9
Message was sent while issue was closed. 
On 2015/02/18 02:18:15, Lei Zhang wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/934173002/ by mailto:thestig@chromium.org.
> 
> The reason for reverting is: Interferes with --show-autofill-type-predictions
> but doesn't offer enough improvements..

thanks for reverting. We can revisit this if we find a site that would benefit.

Powered by Google App Engine
This is Rietveld 408576698