sandbox: Fix Win64 porting issue by using SIZE_T instead of ULONG

sandbox/win/src/nt_internals.h

Index: sandbox/win/src/nt_internals.h
diff --git a/sandbox/win/src/nt_internals.h b/sandbox/win/src/nt_internals.h
index 8b22e0e9a3d0ee5af4472102ef86435f3250a897..2fe27aa8cf000f1d279937de085a3e48d4a2254e 100644
--- a/sandbox/win/src/nt_internals.h
+++ b/sandbox/win/src/nt_internals.h
@@ -450,8 +450,8 @@ typedef NTSTATUS (WINAPI *NtQueryVirtualMemoryFunction)(
   IN PVOID BaseAddress,
   IN MEMORY_INFORMATION_CLASS MemoryInformationClass,
   OUT PVOID MemoryInformation,
-  IN ULONG MemoryInformationLength,
-  OUT PULONG ReturnLength OPTIONAL);
+  IN SIZE_T MemoryInformationLength,
+  OUT PSIZE_T ReturnLength OPTIONAL);

[rvargas (doing something else), 2015/02/17 20:47:30]

We run elf on x64, don't we?. Which means that if this is wrong,
GetBackingModuleFilePath should be failing pretty bad.

[robertshield, 2015/02/17 23:54:43]

Yep.
Possibly. It could also accidentally work / silently fail most of the time
depending on what got passed. We have a very small number of crashes around this
code, mostly on x86 so it doesn't appear to be a case of an unnoticed kaboom.
Will look tomorrow to see if we're not getting the expected stats on x64.

[Reid Kleckner, 2015/02/19 01:57:06]

It might not fail at all if there is no useful data stored 4 bytes prior to the
variable passed in for the outparam. MSVC might just have dead data there.
chrome_elf_unittests pass with Clang in release mode, despite this overwrite.

[rvargas (doing something else), 2015/02/19 02:09:55]

My point was that looking at the code of GetBackingModuleFilePath, I'd say that
this should fail if the sizes are wrong.

So to put it another way, I don't want to change any value from 64 to 32 bits or
viceversa without someone actually making sure that the OS is really expecting
what we pass. Given that we are using some of this code, I'm inclined to say
that it works unless proven wrong.

Note that for the first four arguments we have kind of a free pass as they go in
registers (so the result depends on whatever was in the high part), but after
that, sizes should match the stack use (I think).

 
 typedef NTSTATUS (WINAPI *NtProtectVirtualMemoryFunction)(
   IN HANDLE ProcessHandle,