sandbox: Fix Win64 porting issue by using SIZE_T instead of ULONG

chrome_elf/blacklist/blacklist_interceptions.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Implementation of NtMapViewOfSection intercept for 32 bit builds.
 //
 // TODO(robertshield): Implement the 64 bit intercept.
 
 #include "chrome_elf/blacklist/blacklist_interceptions.h"
 
@@ skipping 33 matching lines @@
 }
 
 // TODO(robertshield): Some of the helper functions below overlap somewhat with
 // code in sandbox_nt_util.cc. See if they can be unified.
 
 // Native reimplementation of PSAPIs GetMappedFileName.
 base::string16 GetBackingModuleFilePath(PVOID address) {
   DCHECK_NT(g_nt_query_virtual_memory_func);
 
   // We'll start with something close to max_path characters for the name.
-  ULONG buffer_bytes = MAX_PATH * 2;
+  SIZE_T buffer_bytes = MAX_PATH * 2;
   std::vector<BYTE> buffer_data(buffer_bytes);
 
   for (;;) {
     MEMORY_SECTION_NAME* section_name =
         reinterpret_cast<MEMORY_SECTION_NAME*>(&buffer_data[0]);
 
     if (!section_name)
       break;
 
-    ULONG returned_bytes;
+    SIZE_T returned_bytes;
     NTSTATUS ret = g_nt_query_virtual_memory_func(
         NtCurrentProcess, address, MemorySectionName, section_name,
         buffer_bytes, &returned_bytes);
 
     if (STATUS_BUFFER_OVERFLOW == ret) {
       // Retry the call with the given buffer size.
       buffer_bytes = returned_bytes + 1;
       buffer_data.resize(buffer_bytes);
       section_name = NULL;
       continue;
@@ skipping 13 matching lines @@
 bool IsModuleValidImageSection(HANDLE section,
                                PVOID *base,
                                PLARGE_INTEGER offset,
                                PSIZE_T view_size) {
   DCHECK_NT(g_nt_query_section_func);
 
   if (!section || !base || !view_size || offset)
     return false;
 
   SECTION_BASIC_INFORMATION basic_info;
   SIZE_T bytes_returned;

[Nico, 2015/02/19 02:07:09]

should this be PULONG now?

[Reid Kleckner, 2015/02/19 21:19:30]

Huh, I did that locally to fix the build, but it didn't make the patch upload.

   NTSTATUS ret = g_nt_query_section_func(section, SectionBasicInformation,
                                          &basic_info, sizeof(basic_info),
                                          &bytes_returned);
 
   if (!NT_SUCCESS(ret) || sizeof(basic_info) != bytes_returned)
     return false;
 
   if (!(basic_info.Attributes & SEC_IMAGE))
     return false;
 
@@ skipping 158 matching lines @@
 NTSTATUS WINAPI BlNtMapViewOfSection64(
     HANDLE section, HANDLE process, PVOID *base, ULONG_PTR zero_bits,
     SIZE_T commit_size, PLARGE_INTEGER offset, PSIZE_T view_size,
     SECTION_INHERIT inherit, ULONG allocation_type, ULONG protect) {
   return BlNtMapViewOfSection(g_nt_map_view_of_section_func, section, process,
                               base, zero_bits, commit_size, offset, view_size,
                               inherit, allocation_type, protect);
 }
 #endif
 }  // namespace blacklist