Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 921273002: downloads: remove focus row background color. (Closed)

Created:
5 years, 10 months ago by Dan Beam
Modified:
5 years, 10 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

downloads: remove focus row background color. The DOM is currently not set up well for a background color, making this really ugly. I'll get this working in the future, but it'll involve hacking up the HTML structure a bit. BUG=458483 R=groby@chromium.org TEST=visual Committed: https://crrev.com/934dcb177acc5f7d2b2b8d3475abcb5d51c48257 Cr-Commit-Position: refs/heads/master@{#316304}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/browser/resources/downloads/downloads.css View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Dan Beam
5 years, 10 months ago (2015-02-13 20:07:45 UTC) #1
groby-ooo-7-16
lgtm
5 years, 10 months ago (2015-02-13 20:10:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921273002/1
5 years, 10 months ago (2015-02-13 20:12:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-13 22:11:08 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 22:12:07 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/934dcb177acc5f7d2b2b8d3475abcb5d51c48257
Cr-Commit-Position: refs/heads/master@{#316304}

Powered by Google App Engine
This is Rietveld 408576698