Roll NaCl toolchain change.

Roll NaCl toolchain change.

This CL causes gclient runhooks to unpack the NaCl toolchain to
//native_client/toolchain.  It also causes GYP to use the toolchain from that
location rather than unpacking it into the output directory during the build.

This CL adds a landmine to reclaim ~1 GB of disk space.  Landmines are normally
used for correctness issues, in this case it is being used because an additional
1 GB of disk usage could cause random bots to fail.

BUG=456902
Committed: https://crrev.com/4453c50a5dd04a86aa1c5e164b4760f14cac115d
Cr-Commit-Position: refs/heads/master@{#316880}

[Mark Seaborn, 2015-02-13 19:49:48]

mseaborn@chromium.org changed reviewers:
+ mseaborn@chromium.org

[Mark Seaborn, 2015-02-13 19:49:48]

https://codereview.chromium.org/921243002/diff/1/build/get_landmines.py
File build/get_landmines.py (right):

https://codereview.chromium.org/921243002/diff/1/build/get_landmines.py#newco...
build/get_landmines.py:64: print 'Ensure NaCl toolchains are removed from the
output directory (crbug.com/456902)'
Maybe also say: This is not necessary for correctness of the build, it's just
desirable to save space that might not be reclaimed otherwise.

[Sam Clegg, 2015-02-13 19:55:22]

sbc@chromium.org changed reviewers:
+ sbc@chromium.org

[Sam Clegg, 2015-02-13 19:55:23]

https://codereview.chromium.org/921243002/diff/1/build/get_landmines.py
File build/get_landmines.py (right):

https://codereview.chromium.org/921243002/diff/1/build/get_landmines.py#newco...
build/get_landmines.py:64: print 'Ensure NaCl toolchains are removed from the
output directory (crbug.com/456902)'
On 2015/02/13 19:49:48, Mark Seaborn wrote:
> Maybe also say: This is not necessary for correctness of the build, it's just
> desirable to save space that might not be reclaimed otherwise.

Is that enough of a reason for an entry in landmines?

[Nick Bray (chromium), 2015-02-17 18:37:17]

ncbray@chromium.org changed reviewers:
+ jvoung@chromium.org

[Nick Bray (chromium), 2015-02-17 18:37:17]

+jvoung because I discovered a PNaCl dependency.

https://codereview.chromium.org/921243002/diff/1/build/get_landmines.py
File build/get_landmines.py (right):

https://codereview.chromium.org/921243002/diff/1/build/get_landmines.py#newco...
build/get_landmines.py:64: print 'Ensure NaCl toolchains are removed from the
output directory (crbug.com/456902)'
On 2015/02/13 19:49:48, Mark Seaborn wrote:
> Maybe also say: This is not necessary for correctness of the build, it's just
> desirable to save space that might not be reclaimed otherwise.

Adding a comment or making the line longer than 80 characters is against the
style of the file.  It seems better to document this in the commit message.

re: enough of a reason?  We had bots fail due to disk space issues today.

[jvoung (off chromium), 2015-02-17 18:49:23]

pnacl_support_extension.gyp LGTM

[bradn, 2015-02-17 19:25:27]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2015-02-17 19:25:28]

lgtm

[Nick Bray (chromium), 2015-02-17 22:30:18]

New patchsets have been uploaded after l-g-t-m from
jvoung@chromium.org,bradnelson@google.com

[Nick Bray (chromium), 2015-02-17 22:34:54]

ncbray@chromium.org changed reviewers:
+ thakis@chromium.org

[Nick Bray (chromium), 2015-02-17 22:34:55]

+thakis as //build / landmine owner.

[Mark Seaborn, 2015-02-17 22:46:13]

https://codereview.chromium.org/921243002/diff/40001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/build_sdk.py (right):

https://codereview.chromium.org/921243002/diff/40001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/build_sdk.py:351: 'libnacl.a',
Can you remove libnacl and others from here now?

[Nick Bray (chromium), 2015-02-17 23:34:17]

https://codereview.chromium.org/921243002/diff/40001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/build_sdk.py (right):

https://codereview.chromium.org/921243002/diff/40001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/build_sdk.py:351: 'libnacl.a',
On 2015/02/17 22:46:13, Mark Seaborn wrote:
> Can you remove libnacl and others from here now?

I can TODO it.  My lodestone for this two-sided set of changes is removing the
out/Release/gen/sdk directory.  (Which is why I removed the copy of these files
NaCl-side: they were being copied into the directory I was removing.)  This file
list is a pre-existing strangeness that doesn't impact removing the directory...
and I am already on thin ice doing a 2-sided change.

[Sam Clegg, 2015-02-17 23:37:57]

On 2015/02/17 23:34:17, Nick Bray (chromium) wrote:
>
https://codereview.chromium.org/921243002/diff/40001/native_client_sdk/src/bu...
> File native_client_sdk/src/build_tools/build_sdk.py (right):
> 
>
https://codereview.chromium.org/921243002/diff/40001/native_client_sdk/src/bu...
> native_client_sdk/src/build_tools/build_sdk.py:351: 'libnacl.a',
> On 2015/02/17 22:46:13, Mark Seaborn wrote:
> > Can you remove libnacl and others from here now?
> 
> I can TODO it.  My lodestone for this two-sided set of changes is removing the
> out/Release/gen/sdk directory.  (Which is why I removed the copy of these
files
> NaCl-side: they were being copied into the directory I was removing.)  This
file
> list is a pre-existing strangeness that doesn't impact removing the
directory...
> and I am already on thin ice doing a 2-sided change.

Feel free to TODO that to me if you like..

[Nico, 2015-02-18 03:24:03]

lgtm

[Nick Bray (chromium), 2015-02-18 17:40:15]

New patchsets have been uploaded after l-g-t-m from thakis@chromium.org

[Nick Bray (chromium), 2015-02-18 19:35:46]

The CQ bit was checked by ncbray@chromium.org

[commit-bot: I haz the power, 2015-02-18 19:36:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/921243002/100001

[commit-bot: I haz the power, 2015-02-18 19:43:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-18 19:43:21]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Sam Clegg, 2015-02-18 20:04:29]

native_client_sdk lgtm

[Nick Bray (chromium), 2015-02-18 20:06:07]

The CQ bit was checked by ncbray@chromium.org

[commit-bot: I haz the power, 2015-02-18 20:06:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/921243002/100001

[commit-bot: I haz the power, 2015-02-18 20:11:07]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-02-18 20:11:57]

Patchset 6 (id:??) landed as
https://crrev.com/4453c50a5dd04a86aa1c5e164b4760f14cac115d
Cr-Commit-Position: refs/heads/master@{#316880}