Cpp bindings: Return false from Validator::Accept() on unrecognized message or invalid flags

mojo/public/js/validation_unittests.js

Index: mojo/public/js/validation_unittests.js
diff --git a/mojo/public/js/validation_unittests.js b/mojo/public/js/validation_unittests.js
index a04879cd4b00f3bda1d466b88837bcdcae35371d..c315ca98e9f6309ed08b08059b1a04cc9fb45a3f 100644
--- a/mojo/public/js/validation_unittests.js
+++ b/mojo/public/js/validation_unittests.js
@@ -225,11 +225,14 @@ define([
     expect(testFiles.length).toBeGreaterThan(0);
 
     for (var i = 0; i < testFiles.length; i++) {
-      // TODO(hansmuller, yzshen): Temporarily skipping:
+      // TODO(hansmuller, yzshen, rudominer): Temporarily skipping:
       //   - array pointer overflow tests;
       //   - struct versioning tests (tests with "mthd11" in the name).
+      //   - no-such-method validation check tests.
       if (testFiles[i].indexOf("overflow") != -1 ||
-          testFiles[i].indexOf("mthd11") != -1) {
+          testFiles[i].indexOf("mthd11") != -1 ||
+          testFiles[i].indexOf("no_such_method") != -1 ||
+          testFiles[i].indexOf("invalid_request_flags") != -1) {

[hansmuller1, 2015/03/04 21:55:20]

The comment no longer covers all the tests being skipped
(invalid_request_flags).

We don't support the overflow tests because JS numbers are limited to 53 bits.
Why are we skipping anything else?

[rudominer, 2015/03/04 23:05:48]

I modified the comment. ptal.

         console.log("[Skipping " + testFiles[i] + "]");
         continue;
       }
@@ -257,12 +260,6 @@ define([
     expect(testFiles.length).toBeGreaterThan(0);
 
     for (var i = 0; i < testFiles.length; i++) {
-      // TODO(hansmuller): Temporarily skipping array pointer overflow tests.
-      if (testFiles[i].indexOf("overflow") != -1) {
-        console.log("[Skipping " + testFiles[i] + "]");
-        continue;
-      }
-
       var testMessage = readTestMessage(testFiles[i]);
       var handles = new Array(testMessage.handleCount);
       var testMessagePipe = new core.createMessagePipe();