mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl - Issue 921223002: Cpp bindings: Return false from Validator::Accept() on unrecognized message or invalid flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

Issue 921223002: Cpp bindings: Return false from Validator::Accept() on unrecognized message or invalid flags (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

index 308c8b67a5060845834470782594e599e915e6a6..e6ad28c69b9dabb4bec57d3ae737a0402e13e5bb 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

@@ -273,6 +273,10 @@ bool {{class_name}}ResponseValidator::Accept(mojo::Message* message) {

break;

}

{%- endfor %}

+ default: {

+ // Unrecognized message.

+ return false;

yzshen1 2015/02/17 19:39:35 You also need to do the same for RequestValidator.

rudominer 2015/02/23 19:12:22 Done

+ }

}

{%- endif %}

« no previous file with comments | « no previous file | no next file » | no next file with comments »