Cpp bindings: Return false from Validator::Accept() on unrecognized message or invalid flags

mojo/public/js/validation_unittests.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 define([
     "console",
     "file",
     "gin/test/expect",
     "mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom",
     "mojo/public/js/buffer",
@@ skipping 207 matching lines @@
     if (actualResult != expectedResult)
       console.log("[Test message validation failed: " + testFile + " ]");
     expect(actualResult).toEqual(expectedResult);
   }
 
   function testMessageValidation(key, filters) {
     var testFiles = getMessageTestFiles(key);
     expect(testFiles.length).toBeGreaterThan(0);
 
     for (var i = 0; i < testFiles.length; i++) {
-      // TODO(hansmuller, yzshen): Temporarily skipping:
+      // TODO(hansmuller, yzshen, rudominer): Temporarily skipping:
       //   - array pointer overflow tests;
       //   - struct versioning tests (tests with "mthd11" in the name).
+      //   - no-such-method validation check tests.
       if (testFiles[i].indexOf("overflow") != -1 ||
-          testFiles[i].indexOf("mthd11") != -1) {
+          testFiles[i].indexOf("mthd11") != -1 ||
+          testFiles[i].indexOf("no_such_method") != -1 ||
+          testFiles[i].indexOf("invalid_request_flags") != -1) {

[hansmuller1, 2015/03/04 21:55:20]

The comment no longer covers all the tests being skipped
(invalid_request_flags).

We don't support the overflow tests because JS numbers are limited to 53 bits.
Why are we skipping anything else?

[rudominer, 2015/03/04 23:05:48]

I modified the comment. ptal.

         console.log("[Skipping " + testFiles[i] + "]");
         continue;
       }
 
       var testMessage = readTestMessage(testFiles[i]);
       var handles = new Array(testMessage.handleCount);
       var message = new codec.Message(testMessage.buffer, handles);
       var messageValidator = new validator.Validator(message);
 
       var err = messageValidator.validateMessageHeader();
       for (var j = 0; err === noError && j < filters.length; ++j)
         err = filters[j](messageValidator);
 
       checkValidationResult(testFiles[i], err);
     }
   }
 
   function testConformanceMessageValidation() {
     testMessageValidation("conformance_", [
         testInterface.ConformanceTestInterface.validateRequest]);
   }
 
   function testIntegratedMessageValidation(testFilesPattern) {
     var testFiles = getMessageTestFiles(testFilesPattern);
     expect(testFiles.length).toBeGreaterThan(0);
 
     for (var i = 0; i < testFiles.length; i++) {
-      // TODO(hansmuller): Temporarily skipping array pointer overflow tests.
-      if (testFiles[i].indexOf("overflow") != -1) {
-        console.log("[Skipping " + testFiles[i] + "]");
-        continue;
-      }
-
       var testMessage = readTestMessage(testFiles[i]);
       var handles = new Array(testMessage.handleCount);
       var testMessagePipe = new core.createMessagePipe();
       expect(testMessagePipe.result).toBe(core.RESULT_OK);
 
       var writeMessageValue = core.writeMessage(
           testMessagePipe.handle0,
           new Uint8Array(testMessage.buffer.arrayBuffer),
           new Array(testMessage.handleCount),
           core.WRITE_MESSAGE_FLAG_NONE);
@@ skipping 29 matching lines @@
     testIntegratedMessageValidation("integration_intf_resp");
   }
 
   expect(checkTestMessageParser()).toBeNull();
   testConformanceMessageValidation();
   testIntegratedMessageHeaderValidation();
   testIntegratedResponseMessageValidation();
   testIntegratedRequestMessageValidation();
   this.result = "PASS";
 });