Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 921163003: fix more tricky-float cases in SkRRect validate (Closed)

Created:
5 years, 10 months ago by reed1
Modified:
5 years, 10 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix more tricky-float cases in SkRRect validate BUG=458524, 458522 Committed: https://skia.googlesource.com/skia/+/694b0d115d5efcd663c422d316d2cf3abaa1d354

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -20 lines) Patch
M src/core/SkRRect.cpp View 1 5 chunks +32 lines, -20 lines 2 comments Download
M tests/RoundRectTest.cpp View 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
reed1
ptal
5 years, 10 months ago (2015-02-13 20:40:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921163003/20001
5 years, 10 months ago (2015-02-13 20:40:46 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-13 20:40:46 UTC) #5
robertphillips
lgtm + nits https://codereview.chromium.org/921163003/diff/20001/src/core/SkRRect.cpp File src/core/SkRRect.cpp (right): https://codereview.chromium.org/921163003/diff/20001/src/core/SkRRect.cpp#newcode120 src/core/SkRRect.cpp:120: /** missing spaces here ? https://codereview.chromium.org/921163003/diff/20001/src/core/SkRRect.cpp#newcode390 ...
5 years, 10 months ago (2015-02-13 22:31:04 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 22:33:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/694b0d115d5efcd663c422d316d2cf3abaa1d354

Powered by Google App Engine
This is Rietveld 408576698