Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 921153003: Roll WebRTC 8348:8372, Libjingle 8347:8369 (Closed)

Created:
5 years, 10 months ago by tommi (sloooow) - chröme
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M DEPS View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libjingle/README.chromium View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
tommi
5 years, 10 months ago (2015-02-14 10:38:15 UTC) #2
tommi (sloooow) - chröme
Rebase
5 years, 10 months ago (2015-02-14 10:51:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921153003/2
5 years, 10 months ago (2015-02-14 10:51:28 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:2)
5 years, 10 months ago (2015-02-14 12:03:00 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/7ebcfae1aa016dd3882edab054d597de61edcb00 Cr-Commit-Position: refs/heads/master@{#316385}
5 years, 10 months ago (2015-02-14 12:03:39 UTC) #7
kjellander_chromium
lgtm
5 years, 10 months ago (2015-02-15 20:41:48 UTC) #8
hichris123
This seems to have broken the Win GN builds, can someone revert it & see ...
5 years, 10 months ago (2015-02-15 21:48:03 UTC) #9
kjellander_chromium
5 years, 10 months ago (2015-02-16 07:21:39 UTC) #10
Message was sent while issue was closed.
On 2015/02/15 21:48:03, hichris123 wrote:
> This seems to have broken the Win GN builds, can someone revert it & see if
the
> bots cycle back to green?

This CL is innocent. It's the adding of gn_unittests to the bots that causes
this failure:
http://src.chromium.org/viewvc/chrome?revision=294072&view=revision

Win8 GN started go red after this commit, this build is green:
http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/4736
But Win GN (dbg) went red with this one:
http://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/build...
which is one commit later.

I suggest disabling the failing test for Windows and filing a bug. I'll notify
the upcoming EMEA sheriff about this (battre@chromium.org).

Powered by Google App Engine
This is Rietveld 408576698