chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_browsertest.mm - Issue 921143004: Disable flaky test TestStaggeredDiagonalSwipe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_browsertest.mm

Issue 921143004: Disable flaky test TestStaggeredDiagonalSwipe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed position of DISABLED_ Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_browsertest.mm

diff --git a/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_browsertest.mm b/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_browsertest.mm

index c064f72084e1361b2d893145b052c0e2c9432e5e..5cc957310cd31ffcd59e0a404fd881c5f317ca9a 100644

--- a/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_browsertest.mm

+++ b/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_browsertest.mm

@@ -615,10 +615,12 @@ IN_PROC_BROWSER_TEST_F(ChromeRenderWidgetHostViewMacHistorySwiperTest,

ExpectUrlAndOffset(url2_, 150);

}

+// Disabled for flakiness. crbug.com/378158

+//

// The movements are equal part diagonal, horizontal, and vertical. This should

// not trigger history navigation.

IN_PROC_BROWSER_TEST_F(ChromeRenderWidgetHostViewMacHistorySwiperTest,

- TestStaggeredDiagonalSwipe) {

+ DISABLED_TestStaggeredDiagonalSwipe) {

if (!IsHistorySwipingSupported())

return;

« no previous file with comments | « no previous file | no next file » | no next file with comments »