Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 921123002: Port all of Sky's editing tests to Dart (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
eseidel, ojan
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -142 lines) Patch
M sky/tests/TestExpectations View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/tests/editing/backspace.sky View 2 chunks +12 lines, -7 lines 2 comments Download
M sky/tests/editing/backspace-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/editing/delete_block_contents.sky View 2 chunks +15 lines, -10 lines 0 comments Download
M sky/tests/editing/delete_block_contents-expected.txt View 1 chunk +6 lines, -5 lines 0 comments Download
M sky/tests/editing/replace.sky View 2 chunks +19 lines, -13 lines 0 comments Download
M sky/tests/editing/replace-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/editing/selection.sky View 2 chunks +19 lines, -13 lines 0 comments Download
M sky/tests/editing/selection-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/editing/typing.sky View 2 chunks +12 lines, -6 lines 0 comments Download
M sky/tests/editing/typing-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A sky/tests/resources/event-sender.dart View 1 chunk +109 lines, -0 lines 0 comments Download
D sky/tests/resources/event-sender.sky View 1 chunk +0 lines, -79 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
5 years, 10 months ago (2015-02-13 07:50:33 UTC) #1
eseidel
lgtm https://codereview.chromium.org/921123002/diff/1/sky/tests/editing/backspace.sky File sky/tests/editing/backspace.sky (right): https://codereview.chromium.org/921123002/diff/1/sky/tests/editing/backspace.sky#newcode9 sky/tests/editing/backspace.sky:9: import "../resources/event-sender.dart" as eventSender; Can we make this ...
5 years, 10 months ago (2015-02-13 18:36:59 UTC) #3
abarth-chromium
https://codereview.chromium.org/921123002/diff/1/sky/tests/editing/backspace.sky File sky/tests/editing/backspace.sky (right): https://codereview.chromium.org/921123002/diff/1/sky/tests/editing/backspace.sky#newcode9 sky/tests/editing/backspace.sky:9: import "../resources/event-sender.dart" as eventSender; On 2015/02/13 at 18:36:58, eseidel ...
5 years, 10 months ago (2015-02-13 21:54:37 UTC) #4
abarth-chromium
5 years, 10 months ago (2015-02-13 21:54:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
95eb91c107b5ac93a3681a31a73bcd297c613195 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698