Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 921103003: [Mac] Always launch in tab if bookmark apps are disabled. (Closed)

Created:
5 years, 10 months ago by jackhou1
Modified:
5 years, 10 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Always launch in tab if bookmark apps are disabled. BUG=437137 Committed: https://crrev.com/8b77ff0fce1a0f480867157b51b70164eed5fac3 Cr-Commit-Position: refs/heads/master@{#316516}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use IsNewBookmarkAppsEnabled #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/extensions/launch_util.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jackhou1
benwells, could you take a look? I tested out what happens when hosted apps have ...
5 years, 10 months ago (2015-02-16 06:28:59 UTC) #2
benwells
https://codereview.chromium.org/921103003/diff/1/chrome/browser/extensions/launch_util.cc File chrome/browser/extensions/launch_util.cc (right): https://codereview.chromium.org/921103003/diff/1/chrome/browser/extensions/launch_util.cc#newcode57 chrome/browser/extensions/launch_util.cc:57: switches::kDisableNewBookmarkApps) && Please use IsNewBookmarkAppsEnabled instead (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/extensions/extension_util.h&l=144).
5 years, 10 months ago (2015-02-16 07:52:19 UTC) #3
jackhou1
https://codereview.chromium.org/921103003/diff/1/chrome/browser/extensions/launch_util.cc File chrome/browser/extensions/launch_util.cc (right): https://codereview.chromium.org/921103003/diff/1/chrome/browser/extensions/launch_util.cc#newcode57 chrome/browser/extensions/launch_util.cc:57: switches::kDisableNewBookmarkApps) && On 2015/02/16 07:52:19, benwells wrote: > Please ...
5 years, 10 months ago (2015-02-16 23:20:27 UTC) #4
benwells
lgtm
5 years, 10 months ago (2015-02-17 00:14:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921103003/20001
5 years, 10 months ago (2015-02-17 00:51:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-17 00:54:03 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 00:54:40 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/8b77ff0fce1a0f480867157b51b70164eed5fac3
Cr-Commit-Position: refs/heads/master@{#316516}

Powered by Google App Engine
This is Rietveld 408576698