Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 921083003: Revert of [Oilpan] Set stack limit using estimated sizes (Closed)

Created:
5 years, 10 months ago by tkent
Modified:
5 years, 10 months ago
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of [Oilpan] Set stack limit using estimated sizes (patchset #11 id:220001 of https://codereview.chromium.org/910663002/) Reason for revert: Broke HeapTest.TraceDeepEagerly. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/44281 Original issue's description: > Set the stack limit size based on estimated sizes. > > To check if the stack memory has enough room for recursive > calls, we tried to allocate a large object and assumed the size. > This CL estimate the real thread stack limit using APIs. > In some cases which such APIs do not work correctly, we set > the limit using the old algorithm. > (AFAIK ChromeOS and MacOSX need the old method.) > > > BUG=420515, 457982 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190239 TBR=oilpan-reviews@chromium.org,kouhei@chromium.org,haraken@chromium.org,peria@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=420515, 457982 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190242

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -45 lines) Patch
M Source/platform/heap/StackFrameDepth.cpp View 3 chunks +6 lines, -42 lines 0 comments Download
M Source/platform/heap/ThreadState.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tkent
Created Revert of [Oilpan] Set stack limit using estimated sizes
5 years, 10 months ago (2015-02-16 10:40:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921083003/1
5 years, 10 months ago (2015-02-16 10:41:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=190242
5 years, 10 months ago (2015-02-16 10:42:02 UTC) #3
blink-reviews
lgtm On Mon, Feb 16, 2015 at 7:42 PM, <commit-bot@chromium.org> wrote: > Committed patchset #1 ...
5 years, 10 months ago (2015-02-16 10:42:45 UTC) #4
haraken
5 years, 10 months ago (2015-02-16 10:45:28 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698