chrome/browser/android/chrome_jni_registrar.cc - Issue 921073002: [App banners] Break apart AppBannerManager and AppBannerInfoBarDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/chrome_jni_registrar.cc

Issue 921073002: [App banners] Break apart AppBannerManager and AppBannerInfoBarDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/banners/app_banner_manager.cc ('k') | chrome/browser/ui/android/infobars/app_banner_infobar.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/chrome_jni_registrar.cc

diff --git a/chrome/browser/android/chrome_jni_registrar.cc b/chrome/browser/android/chrome_jni_registrar.cc

index 88eb4f0a43e112dfd8d14a1d79eee6f043749762..88ef2bc66314c3fee9bcb926e50060ad99894fed 100644

--- a/chrome/browser/android/chrome_jni_registrar.cc

+++ b/chrome/browser/android/chrome_jni_registrar.cc

@@ -80,6 +80,7 @@

#include "chrome/browser/ui/android/autofill/password_generation_popup_view_android.h"

#include "chrome/browser/ui/android/chrome_http_auth_handler.h"

#include "chrome/browser/ui/android/context_menu_helper.h"

+#include "chrome/browser/ui/android/infobars/app_banner_infobar.h"

#include "chrome/browser/ui/android/infobars/confirm_infobar.h"

#include "chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.h"

#include "chrome/browser/ui/android/infobars/generated_password_saved_infobar.h"

@@ -127,7 +128,8 @@ static base::android::RegistrationMethod kChromeRegisteredMethods[] = {

{"AndroidProfileOAuth2TokenService",

AndroidProfileOAuth2TokenService::Register},

{"AnswersImageBridge", RegisterAnswersImageBridge},

- {"AppBannerInfoBarDelegate", RegisterAppBannerInfoBarDelegate},

+ {"AppBannerInfoBar", RegisterAppBannerInfoBar},

+ {"AppBannerInfoBarDelegate", banners::RegisterAppBannerInfoBarDelegate},

{"AppBannerManager", banners::RegisterAppBannerManager},

{"ApplicationLifetime", RegisterApplicationLifetimeAndroid},

{"AutocompleteControllerAndroid", RegisterAutocompleteControllerAndroid},

« no previous file with comments | « chrome/browser/android/banners/app_banner_manager.cc ('k') | chrome/browser/ui/android/infobars/app_banner_infobar.h » ('j') | no next file with comments »