Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: mojo/tools/mopy/gn.py

Issue 921053003: Add option to allow mojob to specify extra gn args. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Add mojob option Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« mojo/tools/mojob.py ('K') | « mojo/tools/mojob.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/tools/mopy/gn.py
diff --git a/mojo/tools/mopy/gn.py b/mojo/tools/mopy/gn.py
index 831711b7f210194fb3f04a1cbe9f35bdb3a528a5..7b3120b839ce60c581264651c00f284fd8b6a508 100644
--- a/mojo/tools/mopy/gn.py
+++ b/mojo/tools/mopy/gn.py
@@ -74,6 +74,10 @@ def GNArgsForConfig(config):
gn_args["target_cpu"] = config.target_cpu
+ val = config.values.get("self_built_network_service_location")
qsr 2015/03/09 11:58:41 I don't think you want this here. Any reason you w
haltonhuo 2015/03/09 12:13:00 Yes, it is needed, otherwise the "gn gen --args" c
qsr 2015/03/09 13:13:06 You do not want to have anything about this variab
haltonhuo 2015/03/10 06:50:44 Done in patch set 6
+ if (val):
+ gn_args["self_built_network_service_location"] = val
+
return gn_args
« mojo/tools/mojob.py ('K') | « mojo/tools/mojob.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698