Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1192)

Unified Diff: mojo/tools/mojob.py

Issue 921053003: Add option to allow mojob to specify extra gn args. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: fix for qsr's review Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/tools/BUILD.gn ('k') | mojo/tools/mopy/gn.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/tools/mojob.py
diff --git a/mojo/tools/mojob.py b/mojo/tools/mojob.py
index fb9e1441ea52ef93b67b792814fc9d62b3e2caec..b7168ea6137f429933ec9b1cf5b6f28c2630dde8 100755
--- a/mojo/tools/mojob.py
+++ b/mojo/tools/mojob.py
@@ -64,6 +64,9 @@ def _args_to_config(args):
if 'test_results_server' in args:
additional_args['test_results_server'] = args.test_results_server
+ if 'gn_args' in args:
+ additional_args['gn_args'] = args.gn_args
+
return Config(target_os=target_os, target_cpu=target_cpu,
is_debug=args.debug, dcheck_always_on=args.dcheck_always_on,
**additional_args)
@@ -207,6 +210,8 @@ def main():
gn_parser = subparsers.add_parser('gn', parents=[parent_parser],
help='Run gn for mojo (does not sync).')
gn_parser.set_defaults(func=gn)
+ gn_parser.add_argument('--args', help='Specify extra args',
+ default=None, dest='gn_args')
clang_group = gn_parser.add_mutually_exclusive_group()
clang_group.add_argument('--clang', help='Use Clang (default)', default=None,
action='store_true')
« no previous file with comments | « mojo/public/tools/BUILD.gn ('k') | mojo/tools/mopy/gn.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698