Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: mojo/tools/mopy/gn.py

Issue 921053003: Add option to allow mojob to specify extra gn args. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Fix qsr's comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« mojo/tools/mojob.py ('K') | « mojo/tools/mojob.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/tools/mopy/gn.py
diff --git a/mojo/tools/mopy/gn.py b/mojo/tools/mopy/gn.py
index 831711b7f210194fb3f04a1cbe9f35bdb3a528a5..45a91d40dd50f2d5a6a7077f02044e1ec45ec99b 100644
--- a/mojo/tools/mopy/gn.py
+++ b/mojo/tools/mopy/gn.py
@@ -74,6 +74,12 @@ def GNArgsForConfig(config):
gn_args["target_cpu"] = config.target_cpu
+ extra_args = config.values.get("extra_args")
+ if (extra_args):
qsr 2015/03/10 10:02:38 Parenthesis are not needed.
haltonhuo 2015/03/11 05:58:06 Done.
+ for arg in extra_args.split(' '):
qsr 2015/03/10 10:02:38 split() is enough when splitting with whitespaces.
haltonhuo 2015/03/11 05:58:06 Done.
+ (name, val) = arg.split('=')
+ gn_args[name] = val
+
return gn_args
« mojo/tools/mojob.py ('K') | « mojo/tools/mojob.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698