Add option to allow mojob to specify extra gn args.

mojo/tools/mojob.py

 #!/usr/bin/env python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This a simple script to make building/testing Mojo components easier.
 
 import argparse
 from copy import deepcopy
 import os
@@ skipping 46 matching lines @@
 
   if 'builder_name' in args:
     additional_args['builder_name'] = args.builder_name
   if 'build_number' in args:
     additional_args['build_number'] = args.build_number
   if 'master_name' in args:
     additional_args['master_name'] = args.master_name
   if 'test_results_server' in args:
     additional_args['test_results_server'] = args.test_results_server
 
+  if 'extra_args' in args and args.extra_args:
+    for arg in args.extra_args.split(' '):
+      (name, val) = arg.split('=')
+      additional_args[name] = val
+
   return Config(target_os=target_os, target_cpu=target_cpu,
                 is_debug=args.debug, dcheck_always_on=args.dcheck_always_on,
                 **additional_args)
 
 
 def _get_out_dir(config):
   paths = Paths(config)
   return paths.SrcRelPath(paths.build_dir)
 
 
@@ skipping 131 matching lines @@
 
   subparsers = parser.add_subparsers()
 
   sync_parser = subparsers.add_parser('sync', parents=[parent_parser],
       help='Sync using gclient (does not run gn).')
   sync_parser.set_defaults(func=sync)
 
   gn_parser = subparsers.add_parser('gn', parents=[parent_parser],
                                     help='Run gn for mojo (does not sync).')
   gn_parser.set_defaults(func=gn)
+  gn_parser.add_argument('--args', help='Specify extra args for gn phase',

[qsr, 2015/03/09 11:58:41]

No need to specify that it is for the gn phase. This parser is only for the gn
phase, so won't be used for anything else.

[haltonhuo, 2015/03/09 12:13:00]

It is added only under "gn" sub-command, did I missing something?

[qsr, 2015/03/09 13:13:06]

 I meant that you do not need to speak about the gn phasein the help message.
Just have 'Specify extra args'

[haltonhuo, 2015/03/10 06:50:43]

Done in patch set 6.

+                         default=None, dest='extra_args')
   clang_group = gn_parser.add_mutually_exclusive_group()
   clang_group.add_argument('--clang', help='Use Clang (default)', default=None,
                            action='store_true')
   clang_group.add_argument('--gcc', help='Use GCC',
                            dest='clang', action='store_false')
   goma_group = gn_parser.add_mutually_exclusive_group()
   goma_group.add_argument('--goma',
                           help='Use Goma (if $GOMA_DIR is set or $HOME/goma '
                                'exists; default)',
                           default=True,
@@ skipping 28 matching lines @@
       help='Run the dart source code analyzer to check for warnings.')
   dartcheck_parser.set_defaults(func=dartcheck)
 
   args = parser.parse_args()
   config = _args_to_config(args)
   return args.func(config)
 
 
 if __name__ == '__main__':
   sys.exit(main())