Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: mojo/tools/mojob.py

Issue 921053003: Add option to allow mojob to specify extra gn args. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Fix qsr's comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2014 The Chromium Authors. All rights reserved. 2 # Copyright 2014 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 # This a simple script to make building/testing Mojo components easier. 6 # This a simple script to make building/testing Mojo components easier.
7 7
8 import argparse 8 import argparse
9 from copy import deepcopy 9 from copy import deepcopy
10 import os 10 import os
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 57
58 if 'builder_name' in args: 58 if 'builder_name' in args:
59 additional_args['builder_name'] = args.builder_name 59 additional_args['builder_name'] = args.builder_name
60 if 'build_number' in args: 60 if 'build_number' in args:
61 additional_args['build_number'] = args.build_number 61 additional_args['build_number'] = args.build_number
62 if 'master_name' in args: 62 if 'master_name' in args:
63 additional_args['master_name'] = args.master_name 63 additional_args['master_name'] = args.master_name
64 if 'test_results_server' in args: 64 if 'test_results_server' in args:
65 additional_args['test_results_server'] = args.test_results_server 65 additional_args['test_results_server'] = args.test_results_server
66 66
67 if 'extra_args' in args:
68 additional_args['extra_args'] = args.extra_args
qsr 2015/03/10 10:02:38 Could you use gn_args instead of extra_args?
haltonhuo 2015/03/11 05:58:06 Done.
69
67 return Config(target_os=target_os, target_cpu=target_cpu, 70 return Config(target_os=target_os, target_cpu=target_cpu,
68 is_debug=args.debug, dcheck_always_on=args.dcheck_always_on, 71 is_debug=args.debug, dcheck_always_on=args.dcheck_always_on,
69 **additional_args) 72 **additional_args)
70 73
71 74
72 def _get_out_dir(config): 75 def _get_out_dir(config):
73 paths = Paths(config) 76 paths = Paths(config)
74 return paths.SrcRelPath(paths.build_dir) 77 return paths.SrcRelPath(paths.build_dir)
75 78
76 79
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 211
209 subparsers = parser.add_subparsers() 212 subparsers = parser.add_subparsers()
210 213
211 sync_parser = subparsers.add_parser('sync', parents=[parent_parser], 214 sync_parser = subparsers.add_parser('sync', parents=[parent_parser],
212 help='Sync using gclient (does not run gn).') 215 help='Sync using gclient (does not run gn).')
213 sync_parser.set_defaults(func=sync) 216 sync_parser.set_defaults(func=sync)
214 217
215 gn_parser = subparsers.add_parser('gn', parents=[parent_parser], 218 gn_parser = subparsers.add_parser('gn', parents=[parent_parser],
216 help='Run gn for mojo (does not sync).') 219 help='Run gn for mojo (does not sync).')
217 gn_parser.set_defaults(func=gn) 220 gn_parser.set_defaults(func=gn)
221 gn_parser.add_argument('--args', help='Specify extra args',
222 default=None, dest='extra_args')
218 clang_group = gn_parser.add_mutually_exclusive_group() 223 clang_group = gn_parser.add_mutually_exclusive_group()
219 clang_group.add_argument('--clang', help='Use Clang (default)', default=None, 224 clang_group.add_argument('--clang', help='Use Clang (default)', default=None,
220 action='store_true') 225 action='store_true')
221 clang_group.add_argument('--gcc', help='Use GCC', 226 clang_group.add_argument('--gcc', help='Use GCC',
222 dest='clang', action='store_false') 227 dest='clang', action='store_false')
223 goma_group = gn_parser.add_mutually_exclusive_group() 228 goma_group = gn_parser.add_mutually_exclusive_group()
224 goma_group.add_argument('--goma', 229 goma_group.add_argument('--goma',
225 help='Use Goma (if $GOMA_DIR is set or $HOME/goma ' 230 help='Use Goma (if $GOMA_DIR is set or $HOME/goma '
226 'exists; default)', 231 'exists; default)',
227 default=True, 232 default=True,
(...skipping 28 matching lines...) Expand all
256 help='Run the dart source code analyzer to check for warnings.') 261 help='Run the dart source code analyzer to check for warnings.')
257 dartcheck_parser.set_defaults(func=dartcheck) 262 dartcheck_parser.set_defaults(func=dartcheck)
258 263
259 args = parser.parse_args() 264 args = parser.parse_args()
260 config = _args_to_config(args) 265 config = _args_to_config(args)
261 return args.func(config) 266 return args.func(config)
262 267
263 268
264 if __name__ == '__main__': 269 if __name__ == '__main__':
265 sys.exit(main()) 270 sys.exit(main())
OLDNEW
« no previous file with comments | « mojo/public/tools/BUILD.gn ('k') | mojo/tools/mopy/gn.py » ('j') | mojo/tools/mopy/gn.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698