[Gallery app] Make the background page use BackgroundBase class

[Gallery app] Make the background page use BackgroundBase class

This is a cleanup and should change no functionality. See the issue for detail.

BUG=442214
TEST=browser_test passes
R=fukino@chromium.org

Committed: https://crrev.com/12618036be0ed3ca286eada1e0c127762f986c6b
Cr-Commit-Position: refs/heads/master@{#317031}

[yoshiki, 2015-02-13 12:27:50]

yoshiki@chromium.org changed reviewers:
+ fukino@chromium.org

[yoshiki, 2015-02-13 12:28:02]

@fukino-san, PTAL. Thanks.

[fukino, 2015-02-16 04:16:38]

lgtm with nits.
Regarding type annotations, please make sure the gallery compiles.
Thanks!

https://codereview.chromium.org/921043004/diff/20001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/background.js (right):

https://codereview.chromium.org/921043004/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/background.js:40: * @type {AsyncUtil.Queue}
nit: This annotation looks incorrect.

https://codereview.chromium.org/921043004/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/background.js:52: function onLaunched(launchData) {
nit: Could you move inline comments from the previous code to here?

// Skip if files are not selected.	

and

// Obtains entries in non-isolated file systems.	
// The entries in launchData are stored in the isolated file system.	
// We need to map the isolated entries to the normal entries to retrieve	
// their parent directory.

https://codereview.chromium.org/921043004/diff/20001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/gallery.js (right):

https://codereview.chromium.org/921043004/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/gallery.js:916: * @param {!BackgroundComponents}
backgroundComponents Background components.
nit: This comment looks incorrect.

https://codereview.chromium.org/921043004/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/gallery.js:934: * @param {!Array.<Entry>}
selectedEntries Array of selected entries.
ditto

[yoshiki, 2015-02-16 07:07:54]

New patchsets have been uploaded after l-g-t-m from fukino@chromium.org

[yoshiki, 2015-02-16 07:35:55]

Thanks for reviewing. I've checked new patch with closure compiler.

https://codereview.chromium.org/921043004/diff/20001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/background.js (right):

https://codereview.chromium.org/921043004/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/background.js:40: * @type {AsyncUtil.Queue}
On 2015/02/16 04:16:38, fukino wrote:
> nit: This annotation looks incorrect.

Done.

https://codereview.chromium.org/921043004/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/background.js:40: * @type {AsyncUtil.Queue}
On 2015/02/16 04:16:38, fukino wrote:
> nit: This annotation looks incorrect.

Done.

https://codereview.chromium.org/921043004/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/background.js:52: function onLaunched(launchData) {
On 2015/02/16 04:16:38, fukino wrote:
> nit: Could you move inline comments from the previous code to here?
> 
> // Skip if files are not selected.	
> 
> and
> 
> // Obtains entries in non-isolated file systems.	
> // The entries in launchData are stored in the isolated file system.	
> // We need to map the isolated entries to the normal entries to retrieve	
> // their parent directory.

Done.

https://codereview.chromium.org/921043004/diff/20001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/gallery.js (right):

https://codereview.chromium.org/921043004/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/gallery.js:916: * @param {!BackgroundComponents}
backgroundComponents Background components.
On 2015/02/16 04:16:38, fukino wrote:
> nit: This comment looks incorrect.

Done.

https://codereview.chromium.org/921043004/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/gallery.js:934: * @param {!Array.<Entry>}
selectedEntries Array of selected entries.
On 2015/02/16 04:16:38, fukino wrote:
> ditto

Done.

[yoshiki, 2015-02-16 07:35:59]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2015-02-16 07:36:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/921043004/40001

[commit-bot: I haz the power, 2015-02-16 07:39:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-16 07:39:21]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng...)
  ios_rel_device_ninja_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yoshiki, 2015-02-19 11:17:42]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2015-02-19 11:18:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/921043004/60001

[commit-bot: I haz the power, 2015-02-19 11:42:14]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-19 11:43:08]

Patchset 4 (id:??) landed as
https://crrev.com/12618036be0ed3ca286eada1e0c127762f986c6b
Cr-Commit-Position: refs/heads/master@{#317031}