Issue 921043002: Subzero: Honor the Internal flag when filetype=asm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 921043002: Subzero: Honor the Internal flag when filetype=asm. (Closed)

Created:
5 years, 10 months ago by Jim Stichnoth

Modified:
5 years, 10 months ago

Reviewers:
jvoung (off chromium), Karl

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Subzero: Honor the Internal flag when filetype=asm. When filetype=asm, the Internal flag of the Cfg wasn't being copied to the Assembler, so all symbols were made global. This would cause multiply defined symbols in Spec, particularly main(). BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=24824e758ebc93f8073e64b12d0525005e82b0d1

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/IceGlobalContext.cpp	View		2 chunks	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Jim Stichnoth

5 years, 10 months ago (2015-02-13 05:35:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
24824e758ebc93f8073e64b12d0525005e82b0d1 (presubmit successful).