content/child/navigator_connect/navigator_connect_provider.cc - Issue 921013002: Optionally have MessagePort pass data as base::Value, part 1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/navigator_connect/navigator_connect_provider.cc

Issue 921013002: Optionally have MessagePort pass data as base::Value, part 1. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@n-c-move-v8-value-converter

Patch Set: Update singly-included comment Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/shared_worker/shared_worker_service_impl_unittest.cc ('k') | content/child/webmessageportchannel_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/navigator_connect/navigator_connect_provider.cc

diff --git a/content/child/navigator_connect/navigator_connect_provider.cc b/content/child/navigator_connect/navigator_connect_provider.cc

index d650a18fd19f08f718fa74635aa34f924cc8b738..415b7a3457a408a5c51745565d2a3a12ec8d2d37 100644

--- a/content/child/navigator_connect/navigator_connect_provider.cc

+++ b/content/child/navigator_connect/navigator_connect_provider.cc

@@ -87,8 +87,9 @@ void NavigatorConnectProvider::OnConnectResult(int thread_id,

DCHECK(callbacks);

if (allow_connect) {

- callbacks->onSuccess(new WebMessagePortChannelImpl(

- message_port_route_id, message_port_id, main_loop_));

+ WebMessagePortChannelImpl* channel = new WebMessagePortChannelImpl(

+ message_port_route_id, message_port_id, main_loop_);

+ callbacks->onSuccess(channel);

} else {

callbacks->onError();

}

« no previous file with comments | « content/browser/shared_worker/shared_worker_service_impl_unittest.cc ('k') | content/child/webmessageportchannel_impl.h » ('j') | no next file with comments »