Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 920993003: Fix compilation for the case dcheck_always_on=1. (Closed)

Created:
5 years, 10 months ago by loislo
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix compilation for the case dcheck_always_on=1. It is a default option for some try bots. otherwise compilation fails on DCHECK(layout_descriptor->IsConsistentWithMap(*map)); BUG=none LOG=n Committed: https://crrev.com/2cfebcf92e8518f9c970ce72d2c4fabfae4e1e06 Cr-Commit-Position: refs/heads/master@{#26636}

Patch Set 1 #

Patch Set 2 : comments addressed #

Patch Set 3 : comments addressed #

Patch Set 4 : compile error was fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -30 lines) Patch
M test/cctest/test-unboxed-doubles.cc View 1 2 3 16 chunks +59 lines, -30 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
loislo
5 years, 10 months ago (2015-02-13 08:18:29 UTC) #2
Sven Panne
lgtm LGTM, although I'm not totally convinced that this is enough. Conditional interfaces are a ...
5 years, 10 months ago (2015-02-13 09:07:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920993003/20001
5 years, 10 months ago (2015-02-13 09:09:05 UTC) #6
danno
Actually, I've been chatting with Ilya and I think the conditional interface is not the ...
5 years, 10 months ago (2015-02-13 09:12:57 UTC) #8
loislo
comments addressed. PTAL
5 years, 10 months ago (2015-02-13 09:22:16 UTC) #11
danno
lgtm
5 years, 10 months ago (2015-02-13 09:23:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920993003/60001
5 years, 10 months ago (2015-02-13 09:24:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920993003/80001
5 years, 10 months ago (2015-02-13 09:49:35 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 10 months ago (2015-02-13 10:29:18 UTC) #19
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/2cfebcf92e8518f9c970ce72d2c4fabfae4e1e06 Cr-Commit-Position: refs/heads/master@{#26636}
5 years, 10 months ago (2015-02-13 10:29:36 UTC) #20
Igor Sheludko
5 years, 10 months ago (2015-02-16 10:29:10 UTC) #21
Message was sent while issue was closed.
On 2015/02/13 10:29:36, I haz the power (commit-bot) wrote:
> Patchset 4 (id:??) landed as
> https://crrev.com/2cfebcf92e8518f9c970ce72d2c4fabfae4e1e06
> Cr-Commit-Position: refs/heads/master@{#26636}

Thank you for taking care of this!

Powered by Google App Engine
This is Rietveld 408576698