Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Side by Side Diff: net/http/http_stream_factory_impl.cc

Issue 920993002: Added DISABLE_ALTERNATE_PROTOCOLS load flag, and use it for DRP probe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments and added test Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/http/http_stream_factory_impl.h" 5 #include "net/http/http_stream_factory_impl.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/stl_util.h" 10 #include "base/stl_util.h"
11 #include "base/strings/string_number_conversions.h" 11 #include "base/strings/string_number_conversions.h"
12 #include "net/base/load_flags.h"
12 #include "net/base/net_log.h" 13 #include "net/base/net_log.h"
13 #include "net/base/net_util.h" 14 #include "net/base/net_util.h"
14 #include "net/http/http_network_session.h" 15 #include "net/http/http_network_session.h"
15 #include "net/http/http_server_properties.h" 16 #include "net/http/http_server_properties.h"
16 #include "net/http/http_stream_factory_impl_job.h" 17 #include "net/http/http_stream_factory_impl_job.h"
17 #include "net/http/http_stream_factory_impl_request.h" 18 #include "net/http/http_stream_factory_impl_request.h"
18 #include "net/spdy/spdy_http_stream.h" 19 #include "net/spdy/spdy_http_stream.h"
19 #include "url/gurl.h" 20 #include "url/gurl.h"
20 21
21 namespace net { 22 namespace net {
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 WebSocketHandshakeStreamBase::CreateHelper* 100 WebSocketHandshakeStreamBase::CreateHelper*
100 websocket_handshake_stream_create_helper, 101 websocket_handshake_stream_create_helper,
101 const BoundNetLog& net_log) { 102 const BoundNetLog& net_log) {
102 Request* request = new Request(request_info.url, 103 Request* request = new Request(request_info.url,
103 this, 104 this,
104 delegate, 105 delegate,
105 websocket_handshake_stream_create_helper, 106 websocket_handshake_stream_create_helper,
106 net_log); 107 net_log);
107 108
108 GURL alternate_url; 109 GURL alternate_url;
109 AlternateProtocolInfo alternate = 110 AlternateProtocolInfo alternate = GetAlternateProtocolRequestFor(
110 GetAlternateProtocolRequestFor(request_info.url, &alternate_url); 111 request_info.url, request_info.load_flags, &alternate_url);
111 Job* alternate_job = NULL; 112 Job* alternate_job = NULL;
112 if (alternate.protocol != UNINITIALIZED_ALTERNATE_PROTOCOL) { 113 if (alternate.protocol != UNINITIALIZED_ALTERNATE_PROTOCOL) {
113 // Never share connection with other jobs for FTP requests. 114 // Never share connection with other jobs for FTP requests.
114 DCHECK(!request_info.url.SchemeIs("ftp")); 115 DCHECK(!request_info.url.SchemeIs("ftp"));
115 116
116 HttpRequestInfo alternate_request_info = request_info; 117 HttpRequestInfo alternate_request_info = request_info;
117 alternate_request_info.url = alternate_url; 118 alternate_request_info.url = alternate_url;
118 alternate_job = 119 alternate_job =
119 new Job(this, session_, alternate_request_info, priority, 120 new Job(this, session_, alternate_request_info, priority,
120 server_ssl_config, proxy_ssl_config, net_log.net_log()); 121 server_ssl_config, proxy_ssl_config, net_log.net_log());
(...skipping 22 matching lines...) Expand all
143 } 144 }
144 145
145 void HttpStreamFactoryImpl::PreconnectStreams( 146 void HttpStreamFactoryImpl::PreconnectStreams(
146 int num_streams, 147 int num_streams,
147 const HttpRequestInfo& request_info, 148 const HttpRequestInfo& request_info,
148 RequestPriority priority, 149 RequestPriority priority,
149 const SSLConfig& server_ssl_config, 150 const SSLConfig& server_ssl_config,
150 const SSLConfig& proxy_ssl_config) { 151 const SSLConfig& proxy_ssl_config) {
151 DCHECK(!for_websockets_); 152 DCHECK(!for_websockets_);
152 GURL alternate_url; 153 GURL alternate_url;
153 AlternateProtocolInfo alternate = 154 AlternateProtocolInfo alternate = GetAlternateProtocolRequestFor(
154 GetAlternateProtocolRequestFor(request_info.url, &alternate_url); 155 request_info.url, request_info.load_flags, &alternate_url);
155 Job* job = NULL; 156 Job* job = NULL;
156 if (alternate.protocol != UNINITIALIZED_ALTERNATE_PROTOCOL) { 157 if (alternate.protocol != UNINITIALIZED_ALTERNATE_PROTOCOL) {
157 HttpRequestInfo alternate_request_info = request_info; 158 HttpRequestInfo alternate_request_info = request_info;
158 alternate_request_info.url = alternate_url; 159 alternate_request_info.url = alternate_url;
159 job = new Job(this, session_, alternate_request_info, priority, 160 job = new Job(this, session_, alternate_request_info, priority,
160 server_ssl_config, proxy_ssl_config, session_->net_log()); 161 server_ssl_config, proxy_ssl_config, session_->net_log());
161 job->MarkAsAlternate(request_info.url, alternate); 162 job->MarkAsAlternate(request_info.url, alternate);
162 } else { 163 } else {
163 job = new Job(this, session_, request_info, priority, 164 job = new Job(this, session_, request_info, priority,
164 server_ssl_config, proxy_ssl_config, session_->net_log()); 165 server_ssl_config, proxy_ssl_config, session_->net_log());
165 } 166 }
166 preconnect_job_set_.insert(job); 167 preconnect_job_set_.insert(job);
167 job->Preconnect(num_streams); 168 job->Preconnect(num_streams);
168 } 169 }
169 170
170 const HostMappingRules* HttpStreamFactoryImpl::GetHostMappingRules() const { 171 const HostMappingRules* HttpStreamFactoryImpl::GetHostMappingRules() const {
171 return session_->params().host_mapping_rules; 172 return session_->params().host_mapping_rules;
172 } 173 }
173 174
174 AlternateProtocolInfo HttpStreamFactoryImpl::GetAlternateProtocolRequestFor( 175 AlternateProtocolInfo HttpStreamFactoryImpl::GetAlternateProtocolRequestFor(
175 const GURL& original_url, 176 const GURL& original_url,
177 int load_flags,
176 GURL* alternate_url) { 178 GURL* alternate_url) {
177 const AlternateProtocolInfo kNoAlternateProtocol; 179 const AlternateProtocolInfo kNoAlternateProtocol;
178 180
179 if (!session_->params().use_alternate_protocols) 181 if (!session_->params().use_alternate_protocols)
180 return kNoAlternateProtocol; 182 return kNoAlternateProtocol;
181 183
182 if (original_url.SchemeIs("ftp")) 184 if (original_url.SchemeIs("ftp"))
183 return kNoAlternateProtocol; 185 return kNoAlternateProtocol;
184 186
187 if (load_flags & LOAD_DISABLE_ALTERNATE_PROTOCOLS)
188 return kNoAlternateProtocol;
189
185 HostPortPair origin = HostPortPair::FromURL(original_url); 190 HostPortPair origin = HostPortPair::FromURL(original_url);
186 HttpServerProperties& http_server_properties = 191 HttpServerProperties& http_server_properties =
187 *session_->http_server_properties(); 192 *session_->http_server_properties();
188 const AlternateProtocolInfo alternate = 193 const AlternateProtocolInfo alternate =
189 http_server_properties.GetAlternateProtocol(origin); 194 http_server_properties.GetAlternateProtocol(origin);
190 195
191 if (alternate.protocol == UNINITIALIZED_ALTERNATE_PROTOCOL) 196 if (alternate.protocol == UNINITIALIZED_ALTERNATE_PROTOCOL)
192 return kNoAlternateProtocol; 197 return kNoAlternateProtocol;
193 if (alternate.is_broken) { 198 if (alternate.is_broken) {
194 HistogramAlternateProtocolUsage(ALTERNATE_PROTOCOL_USAGE_BROKEN); 199 HistogramAlternateProtocolUsage(ALTERNATE_PROTOCOL_USAGE_BROKEN);
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
294 delete job; 299 delete job;
295 } 300 }
296 301
297 void HttpStreamFactoryImpl::OnPreconnectsComplete(const Job* job) { 302 void HttpStreamFactoryImpl::OnPreconnectsComplete(const Job* job) {
298 preconnect_job_set_.erase(job); 303 preconnect_job_set_.erase(job);
299 delete job; 304 delete job;
300 OnPreconnectsCompleteInternal(); 305 OnPreconnectsCompleteInternal();
301 } 306 }
302 307
303 } // namespace net 308 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698