Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 920963003: Moved scoped_histogram_timer to the main histogram_macros.h. (Closed)

Created:
5 years, 10 months ago by rkaplow
Modified:
5 years, 10 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, rginda+watch_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, erikwright+watch_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved scoped_histogram_timer to the main histogram_macros.h since this is broadly applicable. Use the new timer for Profiler:GetProfile (a new histogram). Of note: the data on chrome://tracing from TRACE_EVENT0("browser", "ProfileManager::GetProfile") matches up very nicely with the data I get out of Profile.GetProfile" on chrome://histograms. Committed: https://crrev.com/7ebf4517633282e80158459e8056eb1c7dc26d69 Cr-Commit-Position: refs/heads/master@{#316227}

Patch Set 1 #

Patch Set 2 : small cleanup #

Patch Set 3 : add the unittest to base.gyp #

Patch Set 4 : remove gyp entries for old unit test in media/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -73 lines) Patch
M base/base.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M base/metrics/histogram_macros.h View 1 1 chunk +21 lines, -0 lines 0 comments Download
A + base/metrics/histogram_macros_unittest.cc View 1 2 1 chunk +16 lines, -16 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_device_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M media/audio/audio_input_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_output_controller.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M media/base/BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D media/base/scoped_histogram_timer.h View 1 chunk +0 lines, -32 lines 0 comments Download
D media/base/scoped_histogram_timer_unittest.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M media/media.gyp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
rkaplow
One comment: I wanted to create a macro which handles both TRACE_EVENT0 and SCOPED_UMA_HISTOGRAM_TIMER, but ...
5 years, 10 months ago (2015-02-12 22:22:06 UTC) #2
Alexei Svitkine (slow)
lgtm
5 years, 10 months ago (2015-02-12 22:28:16 UTC) #3
DaleCurtis
\o/, my code has graduated to the big league :) lgtm
5 years, 10 months ago (2015-02-12 22:40:54 UTC) #7
rpetterson
profiles LGTM
5 years, 10 months ago (2015-02-13 01:09:52 UTC) #10
Nico
I got cc'd mid-cl and it's not clear to me what I'm supposed to do. ...
5 years, 10 months ago (2015-02-13 03:01:08 UTC) #11
rkaplow
On 2015/02/13 03:01:08, Nico wrote: > I got cc'd mid-cl and it's not clear to ...
5 years, 10 months ago (2015-02-13 03:08:55 UTC) #12
Mike Lerman
Not sure why I'm here with rlp? LGTM - profiles
5 years, 10 months ago (2015-02-13 13:43:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920963003/60001
5 years, 10 months ago (2015-02-13 15:25:56 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-13 16:40:19 UTC) #17
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 16:41:03 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7ebf4517633282e80158459e8056eb1c7dc26d69
Cr-Commit-Position: refs/heads/master@{#316227}

Powered by Google App Engine
This is Rietveld 408576698