Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 920953002: Subzero: Use -filetype instead of -ias and -elf-writer. (Closed)

Created:
5 years, 10 months ago by Jim Stichnoth
Modified:
5 years, 10 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Use -filetype instead of -ias and -elf-writer. This matches LLVM's -filetype={obj,asm} options, and also adds -filetype=iasm to get textual rendering with the integrated assembler. It also removes the old illegal combination of -ias=0 -elf-writer. BUG= none R=jvoung@chromium.org, kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=d442e7eed84629ee885934e13a2fad5cf7909485

Patch Set 1 #

Total comments: 2

Patch Set 2 : Explicitly set the output file type for unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -65 lines) Patch
M README.rst View 2 chunks +10 lines, -7 lines 0 comments Download
M pydir/szbuild.py View 2 chunks +6 lines, -6 lines 0 comments Download
M src/IceClFlags.h View 3 chunks +9 lines, -12 lines 0 comments Download
M src/IceDefs.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/IceGlobalContext.cpp View 4 chunks +21 lines, -6 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 3 chunks +12 lines, -4 lines 0 comments Download
M src/llvm2ice.cpp View 7 chunks +16 lines, -18 lines 0 comments Download
M tests_lit/llvm2ice_tests/arith-opt.ll View 1 chunk +1 line, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/elf_container.ll View 2 chunks +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/elf_nodata.ll View 1 chunk +1 line, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/globalinit.pnacl.ll View 1 chunk +5 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/nop-insertion.ll View 1 chunk +4 lines, -4 lines 0 comments Download
M unittest/BitcodeMunge.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Jim Stichnoth
5 years, 10 months ago (2015-02-12 20:44:43 UTC) #2
Karl
Otherwise, LGTM. https://codereview.chromium.org/920953002/diff/1/unittest/BitcodeMunge.cpp File unittest/BitcodeMunge.cpp (left): https://codereview.chromium.org/920953002/diff/1/unittest/BitcodeMunge.cpp#oldcode31 unittest/BitcodeMunge.cpp:31: Flags.setUseIntegratedAssembler(true); // for the MINIMAL build Should ...
5 years, 10 months ago (2015-02-12 21:10:54 UTC) #3
jvoung (off chromium)
lgtm too
5 years, 10 months ago (2015-02-12 21:20:40 UTC) #4
Jim Stichnoth
https://codereview.chromium.org/920953002/diff/1/unittest/BitcodeMunge.cpp File unittest/BitcodeMunge.cpp (left): https://codereview.chromium.org/920953002/diff/1/unittest/BitcodeMunge.cpp#oldcode31 unittest/BitcodeMunge.cpp:31: Flags.setUseIntegratedAssembler(true); // for the MINIMAL build On 2015/02/12 21:10:53, ...
5 years, 10 months ago (2015-02-12 21:45:50 UTC) #6
Jim Stichnoth
5 years, 10 months ago (2015-02-12 22:01:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d442e7eed84629ee885934e13a2fad5cf7909485 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698