Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 92093002: Fix error: unused variable 'kNumTasks'. (Closed)

Created:
7 years ago by justincohen
Modified:
7 years ago
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix error: unused variable 'kNumTasks'. Needed for iOS builds using -Wunused-const-variable. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237713

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M base/memory/shared_memory_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
justincohen
pgervais for review, thakis for OWNERS. PTAL!
7 years ago (2013-11-27 17:19:27 UTC) #1
Nico
lgtm, but why is http://build.chromium.org/p/chromium.mac/builders/iOS%20Simulator%20(dbg) not red?
7 years ago (2013-11-27 17:24:22 UTC) #2
Nico
Oh, I guess Xcode's clang doesn't have -Wunused-const-variable yet, and you have no bots building ...
7 years ago (2013-11-27 17:24:57 UTC) #3
justincohen
As soon as this lands and this CL: https://codereview.chromium.org/66953010/ we will!
7 years ago (2013-11-27 17:25:27 UTC) #4
(unused - use chromium)
On Thu, Nov 28, 2013 at 2:25 AM, <justincohen@chromium.org> wrote: > As soon as this ...
7 years ago (2013-11-27 17:28:54 UTC) #5
justincohen
It's more we can't use chomium clang plugins with xcode build. It's a combination of ...
7 years ago (2013-11-27 17:38:10 UTC) #6
(unused - use chromium)
On Thu, Nov 28, 2013 at 2:38 AM, <justincohen@chromium.org> wrote: > It's more we can't ...
7 years ago (2013-11-27 17:39:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@chromium.org/92093002/1
7 years ago (2013-11-27 18:36:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@chromium.org/92093002/1
7 years ago (2013-11-28 02:52:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@chromium.org/92093002/1
7 years ago (2013-11-28 03:19:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@chromium.org/92093002/1
7 years ago (2013-11-28 03:41:36 UTC) #11
commit-bot: I haz the power
7 years ago (2013-11-28 06:46:39 UTC) #12
Message was sent while issue was closed.
Change committed as 237713

Powered by Google App Engine
This is Rietveld 408576698