Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: build/config/android/rules.gni

Issue 920883002: Use combined native/manual JNI registration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Factor out common code in test Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/android/rules.gni
diff --git a/build/config/android/rules.gni b/build/config/android/rules.gni
index 33dfa37e6c2a33f3a31da77494c5a227540b2976..c99a1d1a5fc97e5cc110d983c072d2b2f54b8a1d 100644
--- a/build/config/android/rules.gni
+++ b/build/config/android/rules.gni
@@ -74,6 +74,12 @@ template("generate_jni") {
rebase_path(jni_generator_jarjar_file, root_build_dir),
]
}
+ if (!is_clang) {
+ # Clang builds currently fail with --native_exports_optional due to
+ # http://llvm.org/bugs/show_bug.cgi?id=22602 - only enable for gcc.
+ # http://crbug.com/442327
+ args += [ "--native_exports_optional" ]
+ }
}
config("jni_includes_${target_name}") {
@@ -184,6 +190,12 @@ template("generate_jar_jni") {
"--includes",
rebase_path(jni_generator_include, root_build_dir),
]
+ if (!is_clang) {
+ # Clang builds currently fail with --native_exports_optional due to
+ # http://llvm.org/bugs/show_bug.cgi?id=22602 - only enable for gcc.
+ # http://crbug.com/442327
+ args += [ "--native_exports_optional" ]
+ }
}
}
« no previous file with comments | « base/android/jni_generator/testNativeExportsOptionalOption.golden ('k') | build/jar_file_jni_generator.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698