android_webview/native/aw_message_port_service_impl.h - Issue 920873003: Return created channels synchronously

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_message_port_service_impl.h

Issue 920873003: Return created channels synchronously (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: disable a test for real and remove a wrong assertion Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/native/aw_message_port_service_impl.h

diff --git a/android_webview/native/aw_message_port_service_impl.h b/android_webview/native/aw_message_port_service_impl.h

index f72f80e16cc1a54c9f6ef3668984c6106909d694..3ab5b88f69edaac3f972d45336ee745705d12cd6 100644

--- a/android_webview/native/aw_message_port_service_impl.h

+++ b/android_webview/native/aw_message_port_service_impl.h

@@ -29,7 +29,7 @@ class AwMessagePortServiceImpl : public AwMessagePortService {

~AwMessagePortServiceImpl() override;

void Init(JNIEnv* env, jobject object);

- void CreateMessageChannel(JNIEnv* env, jobject callback,

+ void CreateMessageChannel(JNIEnv* env, jobjectArray ports,

scoped_refptr<AwMessagePortMessageFilter> filter);

// AwMessagePortService implementation

@@ -56,7 +56,7 @@ private:

int* port1,

int* port2);

void OnMessageChannelCreated(

- base::android::ScopedJavaGlobalRef<jobject>* callback,

+ base::android::ScopedJavaGlobalRef<jobjectArray>* ports,

int* port1,

int* port2);

void AddPort(int message_port_id, AwMessagePortMessageFilter* filter);