Issue 920853002: Add missing ppapi_cpp_objects dependency to pdf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 920853002: Add missing ppapi_cpp_objects dependency to pdf (Closed)

Created:
5 years, 10 months ago by Jiang Jiang

Modified:
5 years, 10 months ago

Reviewers:
jam

CC:
chromium-reviews, jochen (gone - plz use gerrit)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Add missing ppapi_cpp_objects dependency to pdf https://codereview.chromium.org/799643004/ links pdf to ppapi_internal_module, it should link to ppapi_cpp_objects as well. That CL broke disable_nacl==1 builds due to the missing dependency. Committed: https://crrev.com/5cd73c0c2307e6e93680a749991f81b0767a9d47 Cr-Commit-Position: refs/heads/master@{#316112}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	pdf/pdf.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

Jiang Jiang

PTAL, see replies at the end of https://codereview.chromium.org/799643004/

5 years, 10 months ago (2015-02-12 17:18:59 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920853002/1

5 years, 10 months ago (2015-02-12 23:45:45 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-13 01:04:20 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5cd73c0c2307e6e93680a749991f81b0767a9d47
Cr-Commit-Position: refs/heads/master@{#316112}