Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: runtime/vm/debugger.cc

Issue 920813003: Refactor service code and service method parameters (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/isolate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger.cc
diff --git a/runtime/vm/debugger.cc b/runtime/vm/debugger.cc
index 37346599a148b8f0fcb8716f994c092c898d56b4..d9a8d97139f66af3d32b93302b0df2b98327694d 100644
--- a/runtime/vm/debugger.cc
+++ b/runtime/vm/debugger.cc
@@ -19,6 +19,7 @@
#include "vm/object_store.h"
#include "vm/os.h"
#include "vm/port.h"
+#include "vm/service_isolate.h"
#include "vm/service.h"
#include "vm/stack_frame.h"
#include "vm/stub_code.h"
@@ -1069,7 +1070,7 @@ void Debugger::Shutdown() {
delete bpt;
}
// Signal isolate shutdown event.
- if (!Service::IsServiceIsolate(isolate_)) {
+ if (!ServiceIsolate::IsServiceIsolate(isolate_)) {
SignalIsolateEvent(DebuggerEvent::kIsolateShutdown);
}
}
@@ -2131,7 +2132,7 @@ bool Debugger::IsDebuggable(const Function& func) {
if (!func.is_debuggable()) {
return false;
}
- if (Service::IsRunning()) {
+ if (ServiceIsolate::IsRunning()) {
return true;
}
const Class& cls = Class::Handle(func.Owner());
@@ -2269,7 +2270,7 @@ void Debugger::Initialize(Isolate* isolate) {
void Debugger::NotifyIsolateCreated() {
// Signal isolate creation event.
- if (!Service::IsServiceIsolate(isolate_)) {
+ if (!ServiceIsolate::IsServiceIsolate(isolate_)) {
SignalIsolateEvent(DebuggerEvent::kIsolateCreated);
}
}
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698