Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 920813002: chromeos: Cats avatar added to defaults set. (Closed)

Created:
5 years, 10 months ago by merkulova
Modified:
5 years, 10 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, nkostylev+watch_chromium.org, dzhioev+watch_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Cats avatar added to defaults set. BUG=151287 Committed: https://crrev.com/b3039edc49734f17374b1d9d3e2cf2435092a9b4 Cr-Commit-Position: refs/heads/master@{#316249}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Comments addressed. #

Messages

Total messages: 12 (4 generated)
merkulova
Dan as resources owner. Pavel as login/* owner.
5 years, 10 months ago (2015-02-12 14:07:15 UTC) #2
Daniel Erat
lgtm with nits. please also update the changelist description to begin with "chromeos: " so ...
5 years, 10 months ago (2015-02-12 14:18:10 UTC) #3
merkulova
https://codereview.chromium.org/920813002/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js File chrome/browser/resources/chromeos/login/oobe_screen_user_image.js (right): https://codereview.chromium.org/920813002/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js#newcode306 chrome/browser/resources/chromeos/login/oobe_screen_user_image.js:306: On 2015/02/12 14:18:10, Daniel Erat wrote: > nit: delete ...
5 years, 10 months ago (2015-02-12 14:33:06 UTC) #6
dzhioev (left Google)
On 2015/02/12 14:07:15, merkulova wrote: > Dan as resources owner. > Pavel as login/* owner. ...
5 years, 10 months ago (2015-02-13 12:38:09 UTC) #7
Nikita (slow)
lgtm
5 years, 10 months ago (2015-02-13 17:53:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920813002/20001
5 years, 10 months ago (2015-02-13 17:54:21 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-13 18:56:34 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 18:57:52 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b3039edc49734f17374b1d9d3e2cf2435092a9b4
Cr-Commit-Position: refs/heads/master@{#316249}

Powered by Google App Engine
This is Rietveld 408576698