pkg/compiler/lib/src/resolution/class_members.dart - Issue 920763002: Install 'get call' on Closure class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/resolution/class_members.dart

Issue 920763002: Install 'get call' on Closure class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/resolution/class_members.dart

diff --git a/pkg/compiler/lib/src/resolution/class_members.dart b/pkg/compiler/lib/src/resolution/class_members.dart

index aaa40aa3707f472053433d66f0ab443547ce08d0..66d991be193f203c145ed59f616c60ccc9cfb3c3 100644

--- a/pkg/compiler/lib/src/resolution/class_members.dart

+++ b/pkg/compiler/lib/src/resolution/class_members.dart

@@ -399,10 +399,10 @@ abstract class MembersCreator {

} else if (declared.isGetter && inherited.isMethod) {

reportError(MessageKind.CANNOT_OVERRIDE_METHOD_WITH_GETTER,

MessageKind.CANNOT_OVERRIDE_METHOD_WITH_GETTER_CONT);

- } else if (declared.isMethod && inherited.isGetter) {

+ /*} else if (declared.isMethod && inherited.isGetter) {

reportError(MessageKind.CANNOT_OVERRIDE_GETTER_WITH_METHOD,

MessageKind.CANNOT_OVERRIDE_GETTER_WITH_METHOD_CONT);

- } else {

+ */} else {

DartType inheritedType = inherited.functionType;

if (!compiler.types.isSubtype(declaredType, inheritedType)) {

void reportWarning(var marker,